kovagoadi/hunfabric
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

revert service account modules changes to outputs

Browse Source
This commit is contained in:
Ludovico Magnocavallo
2022-06-16 23:09:35 +02:00
parent a35ed1ca0f
commit ee23694fed
2 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
modules/iam-service-account/README.md
View File

@@ -2,6 +2,8 @@
This module allows simplified creation and management of one a service account and its IAM bindings. A key can optionally be generated and will be stored in Terraform state. To use it create a sensitive output in your root modules referencing the `key` output, then extract the private key from the JSON formatted outputs. Alternatively, the `key` can be generated with `openssl` library and only public part uploaded to the Service Account, for more refer to the [Onprem SA Key Management](../../examples/cloud-operations/onprem-sa-key-management/) example.
Note that this module does not fully comply with our design principles, as outputs have no dependencies on IAM bindings to prevent resource cycles.
## Example
```hcl
@@ -62,11 +64,11 @@ module "myproject-default-service-accounts" {
| name | description | sensitive |
|---|---|:---:|
| [email](outputs.tf#L17) | Service account email. | |
| [iam_email](outputs.tf#L27) | IAM-format service account email. | |
| [id](outputs.tf#L37) | Service account id. | |
| [key](outputs.tf#L47) | Service account key. | ✓ |
| [name](outputs.tf#L53) | Service account name. | |
| [service_account](outputs.tf#L58) | Service account resource. | |
| [service_account_credentials](outputs.tf#L63) | Service account json credential templates for uploaded public keys data. | |
| [iam_email](outputs.tf#L25) | IAM-format service account email. | |
| [id](outputs.tf#L33) | Service account id. | |
| [key](outputs.tf#L41) | Service account key. | ✓ |
| [name](outputs.tf#L47) | Service account name. | |
| [service_account](outputs.tf#L52) | Service account resource. | |
| [service_account_credentials](outputs.tf#L57) | Service account json credential templates for uploaded public keys data. | |
<!-- END TFDOC -->

12
modules/iam-service-account/outputs.tf
View File

@@ -18,9 +18,7 @@ output "email" {
description = "Service account email."
value = local.resource_email_static
depends_on = [
local.service_account,
google_service_account_iam_binding.roles,
google_service_account_iam_member.additive
local.service_account
]
}
@@ -28,9 +26,7 @@ output "iam_email" {
description = "IAM-format service account email."
value = local.resource_iam_email_static
depends_on = [
local.service_account,
google_service_account_iam_binding.roles,
google_service_account_iam_member.additive
local.service_account
]
}
@@ -38,9 +34,7 @@ output "id" {
description = "Service account id."
value = local.service_account.id
depends_on = [
local.service_account,
google_service_account_iam_binding.roles,
google_service_account_iam_member.additive
local.service_account
]
}