Fixed small typo in project-factory module with log-buckets (#3357)

* Fixed small typo in project-factory module

* Add log_analytics and retention to log_buckets

fast/stages/0-org-setup/data/projects/core/log-0.yaml

@@ -27,4 +27,7 @@ services:
 log_buckets:
   audit-logs: {}
   iam: {}
-  vpc-sc: {}
+  vpc-sc:
+    log_analytics:
+      enable: true
+    retention: 31

modules/project-factory/projects-log-buckets.tf

@@ -27,8 +27,8 @@ locals {
           lookup(local.ctx.locations, opts.location, opts.location),
           "global"
         )
-        retention     = lookup(v, "retention", null)
-        log_analytics = lookup(v, "log_analytics", {})
+        retention     = lookup(opts, "retention", null)
+        log_analytics = lookup(opts, "log_analytics", {})
       }
     ]
   ])

tests/fast/stages/s0_org_setup/not-simple.yaml

@@ -1002,12 +1002,12 @@ values:
   module.factory.module.log-buckets["log-0/vpc-sc"].google_logging_project_bucket_config.bucket[0]:
     bucket_id: vpc-sc
     cmek_settings: []
-    enable_analytics: false
+    enable_analytics: true
     index_configs: []
     location: global
     locked: null
     project: ft0-prod-audit-logs-0
-    retention_days: 30
+    retention_days: 31
   module.factory.module.projects-iam["iac-0"].google_project_iam_binding.authoritative["$custom_roles:storage_viewer"]:
     condition: []
     members: