Fixed issue with service networking DNS peering (#2246)

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>

modules/net-vpc/psa.tf

@@ -28,7 +28,7 @@ locals {
   _psa_peered_domains = flatten([
     for config in local.psa_configs : [
       for v in config.peered_domains : {
-        key              = "${config.key}-${replace(v, ".", "-")}"
+        key              = "${config.key}-${trimsuffix(replace(v, ".", "-"), "-")}"
         dns_suffix       = v
         service_producer = config.service_producer
       }

tests/modules/net_vpc/examples/psa-routes.yaml

@@ -84,9 +84,9 @@ values:
     - servicenetworking-googleapis-com-myrange
     service: servicenetworking.googleapis.com
     timeouts: null
-  module.vpc.google_service_networking_peered_dns_domain.name["servicenetworking-googleapis-com-gcp-example-com-"]:
+  module.vpc.google_service_networking_peered_dns_domain.name["servicenetworking-googleapis-com-gcp-example-com"]:
     dns_suffix: gcp.example.com.
-    name: servicenetworking-googleapis-com-gcp-example-com-
+    name: servicenetworking-googleapis-com-gcp-example-com
     network: my-network
     project: project-id
     service: servicenetworking.googleapis.com