kovagoadi/openttd-client
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity
57 Commits 1 Branch 0 Tags
3641bf383eb5b535f0bac7c42bb9282f53766570
Commit Graph
4 Commits
Author SHA1 Message Date
kovagoadiandClaude 25953bea06 Fix ruff lint findings across client, protocol, and tests
Continuous Integration / lint-and-security (pull_request) Successful in 20s
Details
Continuous Integration / tests-and-coverage (pull_request) Successful in 25s
Details 
Resolve 51 findings from the I/RUF/BLE/TRY002/S110/PLR0402 rule set:

- Sort imports and __all__ (I001, RUF022, PLR0402). The sys.path.insert
  calls in check_public_calls.py and tests/test_e2e.py still precede the
  openttd imports that depend on them.
- Replace unused unpacked values with _ (RUF059) and annotate the two
  timetable lookup tables as ClassVar (RUF012).
- Narrow the best-effort excepts in OpenTTDClient.quit and
  OpenTTDAdminClient.quit to (OSError, SocketClosed) and log at debug
  rather than swallowing silently (BLE001, S110). The test doubles now
  raise an OSError subclass so they still exercise that branch.
- Narrow the gamescript JSON fallback to json.JSONDecodeError. The broad
  catch in receive_packet keeps a noqa: it guards untrusted wire data and
  must degrade to a no-op packet instead of killing the connection.
- Use contextlib.suppress instead of try/except/pass in tests.

ruff check . is clean, 102 tests pass, coverage stays at 100%.

Co-Authored-By: Claude <[email protected]>
 2026-08-26 20:57:56 +02:00
kovagoadiandClaude Opus 4.8 81a4d9333d Add station listing and cargo queries to admin client
Continuous Integration / lint-and-security (pull_request) Successful in 20s
Details
Continuous Integration / tests-and-coverage (pull_request) Successful in 24s
Details 
Extends the AdminBridge GameScript JSON channel (the same relay used by
list_vehicles/get_timetable) with station support:

- list_stations(): enumerate stations, fire-and-forget like list_vehicles().
- get_station(): authoritative per-cargo snapshot of a station's live state,
  with both the real-time waiting amount (GSStation.GetCargoWaiting) and the
  planned cargodist link-graph flow (GetCargoPlanned), plus rating.
- get_station_cargo(): break one cargo type down by source station and by
  next hop (the cargodist routing destination) for both waiting and planned
  amounts, with optional from_station/via_station filters.

All three use stock GameScript API (no server patch, unlike timetables).
Refactors the shared GS request/reply correlation out of get_timetable and
get_station into a _gs_query() helper. Companion handlers must be added to
the server-side AdminBridge GameScript (not tracked in this repo).

Includes unit + e2e tests, a worked demo in main_admin.py, and protocol docs.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
 2026-07-23 21:48:20 +02:00
kovagoadiandClaude Sonnet 5 0a8271d57c Add vehicle listing support to admin client
Continuous Integration / lint-and-security (pull_request) Successful in 31s
Details
Continuous Integration / tests-and-coverage (pull_request) Successful in 25s
Details 
The Admin Network has no native packet for listing individual vehicles,
so list_vehicles() sends a "list_vehicles" command over the existing
GameScript JSON channel and relies on a companion server-side script to
reply with vehicle data via ServerGamescript. Requires subscribing to
Gamescript updates (documented in docs/PROTOCOL.md) to receive the reply.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
 2026-07-16 20:44:44 +02:00
kovagoadi aebd5f4ef5 Add admin port support with other major refactorations
Continuous Integration / lint-and-security (pull_request) Failing after 39s
Details
Continuous Integration / tests-and-coverage (pull_request) Successful in 24s
Details
2026-06-29 19:47:48 +02:00