Files
hunfabric/modules/iam-service-account/main.tf
Julio Castillo 2eaa0d5e27 Add support for dynamic tags (#3897)
* Allow creation of dynamic tags

* Extend project factory and related modules to support dynamic values

* Extend folder and organization modules

* project and organization readme

* Simplify dynamic tag support and remove unnecessary restrictions

  • Schemas & Validations: Removed the restriction that forbade combining IAM fields with  allowed_values_regex  on tags. Updated validations in  project  and  organization  modules, and
  simplified all relevant JSON schemas.
  • Module Tag Bindings: Simplified the  tag_value  assignment in  folder ,  project ,  gcs ,  bigquery-dataset , and  kms  modules by removing the defensive  can(regex(...))  check and
  calling  templatestring  directly.
  • Outputs: Removed the  tags_dynamic  output from  project  and  organization  modules, as the same information is now available in  tag_keys .
  • Project Factory: Updated  tag_vars_projects  in  projects.tf  to use the native  namespaced_name  attribute and filtered manually for dynamic tags.

* fix(organization, project): fix linting and tests for dynamic tag support

- Align allowed_values_regex and description extraction in _tags_merged
  locals to use lookup() for consistency with other fields.
- Fix spacing in project context variable (alphabetical ordering).
- Update organization tags test to include the new cost_center tag key
  with allowed_values_regex.
- Update project tags test to include the new cost_center tag key and
  reflect the resolved allowed_values_regex on environment.

* refactor(gcs): refine tag bindings and fix context test

- Add _tag_bindings local to pre-resolve context references, enabling
  templatestring to receive a direct map reference (required by Terraform).
- Use var.context.tag_vars instead of the non-existent local.ctx.tag_vars.
- Fix HCL syntax in context.tfvars (escaped inner quotes).
- Update context test inventory to reflect 3 tag bindings including a
  dynamic value resolved via templatestring.

* refactor: align modules with tag binding context pattern

- Add _tag_bindings local + templatestring dance to cloud-run-v2,
  compute-vm, folder, kms modules (bigquery-dataset already had it)
- Exclude tag_vars from local.ctx in cloud-run-v2, compute-vm, folder,
  kms, project modules (bigquery-dataset already had it)
- Add tag_vars to context variable in cloud-run-v2, compute-vm modules
  (others already had it)
- Update all context tests with dynamic tag binding values using
  var.context.tag_vars

* docs: add module-level tftest.yaml test instructions to GEMINI.md

* docs: regenerate READMEs after tag-regex alignment

- Regenerate variable tables in 7 module READMEs to reflect
  line number shifts from prior tag-regex changes
- Add tag_vars exclusion to gcs ctx local
- Fix whitespace alignment in iam-service-account and
  project-factory tag_vars blocks
- Update tftest resource counts for organization and project
- Remove tags_dynamic from organization/project output tables

* fix(project-factory): update test inventory for tag_bindings module split

- Move tag binding address from folder-2 to folder-2-iam in test
  inventory (tag_bindings moved from creation to IAM modules)
- Update module instance count from 34 to 35
- Regenerate README tables after terraform fmt line shifts
- Apply terraform fmt to variables.tf

* refactor(project-factory): remove unnecessary depends_on from folder-iam modules

Folder IAM modules depend on their own folder creation modules, not
on module.projects. The explicit depends_on was leftover from an
earlier design.

* FAST stages

* Address review comments.

- FAST Stages:
  - Added tag_keys to output-files.tf in 0-org-setup to pass org tags via tfvars.
  - Sorted tag_keys and tag_values in output-files.tf.
  - Updated project-factory, networking, and security stages to use tag_keys.
  - Filtered tag_keys for dynamic tags only.
- Modules:
  - Excluded tag_vars from local.ctx in iam-service-account and organization.
  - Simplified tag_value in iam-service-account.
- Tests:
  - Updated test inventories for 0-org-setup and project-factory.

* Fix tf format

* Fix tfdoc

* docs: add ADR for templatestring vars convention and update status of base path ADR

* More tfdoc

* Update schemas

* Use endswith in context loop

* Address review

* Update FAST readmes

* Update last modules

* Terraform fmt

* Revert alloydb

* Fix whitespace

---------

Co-authored-by: Ludovico Magnocavallo <ludo@qix.it>
2026-04-24 20:45:45 +00:00

107 lines
3.6 KiB
HCL

/**
* Copyright 2025 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
locals {
ctx = {
for k, v in var.context : k => {
for kk, vv in v : "${local.ctx_p}${k}:${kk}" => vv
} if !endswith(k, "_vars")
}
ctx_p = "$"
iam_email = (
local.service_account != null
? "serviceAccount:${local.service_account.email}"
: local.static_iam_email
)
name = split("@", var.name)[0]
prefix = var.prefix == null ? "" : "${var.prefix}-"
project_id = (
var.project_id == null
# if no project ID is passed we're reusing and can infer it from the email
? try(regex("^[^@]+@([^.]+)", var.name)[0], null)
# otherwise check if we need context expansion
: lookup(local.ctx.project_ids, var.project_id, var.project_id)
)
static_email = (
var.project_id == null
? var.name
: "${local.prefix}${local.name}@${local.sa_domain}.iam.gserviceaccount.com"
)
static_iam_email = "serviceAccount:${local.static_email}"
static_id = (
"projects/${local.project_id_universe}/serviceAccounts/${local.static_email}"
)
service_account = (
local.use_data_source
? try(data.google_service_account.service_account[0], null)
: try(google_service_account.service_account[0], null)
)
# universe-related locals
universe = try(
regex("^([^:]*):[a-z]", local.project_id)[0],
var.service_account_reuse.universe.prefix,
""
)
use_data_source = (
try(var.service_account_reuse.use_data_source, null) == true
)
project_id_no_universe = element(split(":", local.project_id), 1)
# reassemble project id for cases where we are reusing service account
project_id_universe = (
local.universe == ""
? local.project_id
: "${local.universe}:${local.project_id_no_universe}"
)
sa_domain = join(".", compact([
local.project_id_no_universe, local.universe
]))
# the condition here avoids referring to attributes not known at plan time
tag_bindings = (
var.service_account_reuse != null ||
try(var.service_account_reuse.attributes.unique_id, null) != null
? {}
: var.tag_bindings
)
_tag_bindings = {
for k, v in local.tag_bindings : k => lookup(local.ctx.tag_values, v, v)
}
}
data "google_service_account" "service_account" {
count = local.use_data_source ? 1 : 0
project = (
strcontains(local.project_id, ":")
? join(".", reverse(split(":", local.project_id)))
: local.project_id
)
account_id = "${local.prefix}${local.name}"
}
resource "google_service_account" "service_account" {
count = var.service_account_reuse == null ? 1 : 0
project = local.project_id
account_id = "${local.prefix}${local.name}"
display_name = var.display_name
description = var.description
create_ignore_already_exists = var.create_ignore_already_exists
}
resource "google_tags_tag_binding" "binding" {
for_each = local.tag_bindings
parent = "//iam.googleapis.com/projects/${coalesce(var.project_number, var.project_id)}/serviceAccounts/${local.service_account.unique_id}"
tag_value = templatestring(local._tag_bindings[each.key], var.context.tag_vars)
}