Files
hunfabric/modules/artifact-registry/main.tf
Julio Castillo 2eaa0d5e27 Add support for dynamic tags (#3897)
* Allow creation of dynamic tags

* Extend project factory and related modules to support dynamic values

* Extend folder and organization modules

* project and organization readme

* Simplify dynamic tag support and remove unnecessary restrictions

  • Schemas & Validations: Removed the restriction that forbade combining IAM fields with  allowed_values_regex  on tags. Updated validations in  project  and  organization  modules, and
  simplified all relevant JSON schemas.
  • Module Tag Bindings: Simplified the  tag_value  assignment in  folder ,  project ,  gcs ,  bigquery-dataset , and  kms  modules by removing the defensive  can(regex(...))  check and
  calling  templatestring  directly.
  • Outputs: Removed the  tags_dynamic  output from  project  and  organization  modules, as the same information is now available in  tag_keys .
  • Project Factory: Updated  tag_vars_projects  in  projects.tf  to use the native  namespaced_name  attribute and filtered manually for dynamic tags.

* fix(organization, project): fix linting and tests for dynamic tag support

- Align allowed_values_regex and description extraction in _tags_merged
  locals to use lookup() for consistency with other fields.
- Fix spacing in project context variable (alphabetical ordering).
- Update organization tags test to include the new cost_center tag key
  with allowed_values_regex.
- Update project tags test to include the new cost_center tag key and
  reflect the resolved allowed_values_regex on environment.

* refactor(gcs): refine tag bindings and fix context test

- Add _tag_bindings local to pre-resolve context references, enabling
  templatestring to receive a direct map reference (required by Terraform).
- Use var.context.tag_vars instead of the non-existent local.ctx.tag_vars.
- Fix HCL syntax in context.tfvars (escaped inner quotes).
- Update context test inventory to reflect 3 tag bindings including a
  dynamic value resolved via templatestring.

* refactor: align modules with tag binding context pattern

- Add _tag_bindings local + templatestring dance to cloud-run-v2,
  compute-vm, folder, kms modules (bigquery-dataset already had it)
- Exclude tag_vars from local.ctx in cloud-run-v2, compute-vm, folder,
  kms, project modules (bigquery-dataset already had it)
- Add tag_vars to context variable in cloud-run-v2, compute-vm modules
  (others already had it)
- Update all context tests with dynamic tag binding values using
  var.context.tag_vars

* docs: add module-level tftest.yaml test instructions to GEMINI.md

* docs: regenerate READMEs after tag-regex alignment

- Regenerate variable tables in 7 module READMEs to reflect
  line number shifts from prior tag-regex changes
- Add tag_vars exclusion to gcs ctx local
- Fix whitespace alignment in iam-service-account and
  project-factory tag_vars blocks
- Update tftest resource counts for organization and project
- Remove tags_dynamic from organization/project output tables

* fix(project-factory): update test inventory for tag_bindings module split

- Move tag binding address from folder-2 to folder-2-iam in test
  inventory (tag_bindings moved from creation to IAM modules)
- Update module instance count from 34 to 35
- Regenerate README tables after terraform fmt line shifts
- Apply terraform fmt to variables.tf

* refactor(project-factory): remove unnecessary depends_on from folder-iam modules

Folder IAM modules depend on their own folder creation modules, not
on module.projects. The explicit depends_on was leftover from an
earlier design.

* FAST stages

* Address review comments.

- FAST Stages:
  - Added tag_keys to output-files.tf in 0-org-setup to pass org tags via tfvars.
  - Sorted tag_keys and tag_values in output-files.tf.
  - Updated project-factory, networking, and security stages to use tag_keys.
  - Filtered tag_keys for dynamic tags only.
- Modules:
  - Excluded tag_vars from local.ctx in iam-service-account and organization.
  - Simplified tag_value in iam-service-account.
- Tests:
  - Updated test inventories for 0-org-setup and project-factory.

* Fix tf format

* Fix tfdoc

* docs: add ADR for templatestring vars convention and update status of base path ADR

* More tfdoc

* Update schemas

* Use endswith in context loop

* Address review

* Update FAST readmes

* Update last modules

* Terraform fmt

* Revert alloydb

* Fix whitespace

---------

Co-authored-by: Ludovico Magnocavallo <ludo@qix.it>
2026-04-24 20:45:45 +00:00

248 lines
8.7 KiB
HCL

/**
* Copyright 2026 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
locals {
ctx = {
for k, v in var.context : k => {
for kk, vv in v : "${local.ctx_p}${k}:${kk}" => vv
} if !endswith(k, "_vars")
}
ctx_p = "$"
_tag_bindings = {
for k, v in var.tag_bindings : k => lookup(local.ctx.tag_values, v, v)
}
format_obj = one([for k, v in var.format : v if v != null])
format_string = one([for k, v in var.format : k if v != null])
location = lookup(local.ctx.locations, var.location, var.location)
mode_string = one([for k, v in local.format_obj : k if v != null && v != false])
project_id = lookup(local.ctx.project_ids, var.project_id, var.project_id)
}
resource "google_artifact_registry_repository" "registry" {
provider = google-beta
project = local.project_id
location = local.location
description = var.description
format = upper(local.format_string)
labels = var.labels
repository_id = var.name
mode = "${upper(local.mode_string)}_REPOSITORY"
kms_key_name = var.encryption_key == null ? null : lookup(
local.ctx.kms_keys, var.encryption_key, var.encryption_key
)
cleanup_policy_dry_run = var.cleanup_policy_dry_run
vulnerability_scanning_config {
enablement_config = (
var.enable_vulnerability_scanning == true
? "INHERITED"
: var.enable_vulnerability_scanning == false ? "DISABLED" : null
)
}
dynamic "cleanup_policies" {
for_each = var.cleanup_policies == null ? {} : var.cleanup_policies
content {
id = cleanup_policies.key
action = cleanup_policies.value.action
dynamic "condition" {
for_each = (cleanup_policies.value.condition != null) ? [""] : []
content {
tag_state = cleanup_policies.value.condition.tag_state
tag_prefixes = cleanup_policies.value.condition.tag_prefixes
version_name_prefixes = cleanup_policies.value.condition.version_name_prefixes
package_name_prefixes = cleanup_policies.value.condition.package_name_prefixes
newer_than = cleanup_policies.value.condition.newer_than
older_than = cleanup_policies.value.condition.older_than
}
}
dynamic "most_recent_versions" {
for_each = (cleanup_policies.value.most_recent_versions != null) ? [""] : []
content {
package_name_prefixes = cleanup_policies.value.most_recent_versions.package_name_prefixes
keep_count = cleanup_policies.value.most_recent_versions.keep_count
}
}
}
}
dynamic "docker_config" {
# TODO: open a bug on the provider for this permadiff
for_each = (
local.format_string == "docker" && try(local.format_obj.standard.immutable_tags, null) != null
? [""] : []
)
content {
immutable_tags = local.format_obj.standard.immutable_tags
}
}
dynamic "maven_config" {
for_each = local.format_string == "maven" ? [""] : []
content {
allow_snapshot_overwrites = try(local.format_obj.standard.allow_snapshot_overwrites, null)
version_policy = try(local.format_obj.standard.version_policy, null)
}
}
dynamic "remote_repository_config" {
for_each = local.mode_string == "remote" ? [""] : []
content {
disable_upstream_validation = local.format_obj.remote.disable_upstream_validation
dynamic "upstream_credentials" {
for_each = local.format_obj.remote.upstream_credentials != null ? [""] : []
content {
username_password_credentials {
username = local.format_obj.remote.upstream_credentials.username
password_secret_version = lookup(
local.ctx.secrets,
local.format_obj.remote.upstream_credentials.password_secret_version,
local.format_obj.remote.upstream_credentials.password_secret_version
)
}
}
}
dynamic "apt_repository" {
for_each = local.format_string == "apt" ? [""] : []
content {
public_repository {
repository_base = split(" ", local.format_obj.remote.public_repository)[0]
repository_path = split(" ", local.format_obj.remote.public_repository)[1]
}
# dynamic "custom_repository" {
# for_each = local.format_obj.remote.custom_repository != null ? [""] : []
# content {
# uri = local.format_obj.remote.custom_repository
# }
# }
}
}
dynamic "common_repository" {
for_each = (
local.format_string == "docker" && try(local.format_obj.remote.common_repository, null) != null
? [""] : []
)
content {
uri = local.format_obj.remote.common_repository
}
}
dynamic "docker_repository" {
for_each = (
local.format_string == "docker" && try(local.format_obj.remote.common_repository, null) == null
? [""] : []
)
content {
public_repository = local.format_obj.remote.public_repository
dynamic "custom_repository" {
for_each = local.format_obj.remote.custom_repository != null ? [""] : []
content {
uri = local.format_obj.remote.custom_repository
}
}
}
}
dynamic "maven_repository" {
for_each = local.format_string == "maven" ? [""] : []
content {
public_repository = local.format_obj.remote.public_repository
dynamic "custom_repository" {
for_each = local.format_obj.remote.custom_repository != null ? [""] : []
content {
uri = local.format_obj.remote.custom_repository
}
}
}
}
dynamic "npm_repository" {
for_each = local.format_string == "npm" ? [""] : []
content {
public_repository = local.format_obj.remote.public_repository
dynamic "custom_repository" {
for_each = local.format_obj.remote.custom_repository != null ? [""] : []
content {
uri = local.format_obj.remote.custom_repository
}
}
}
}
dynamic "python_repository" {
for_each = local.format_string == "python" ? [""] : []
content {
public_repository = local.format_obj.remote.public_repository
dynamic "custom_repository" {
for_each = local.format_obj.remote.custom_repository != null ? [""] : []
content {
uri = local.format_obj.remote.custom_repository
}
}
}
}
dynamic "yum_repository" {
for_each = local.format_string == "yum" ? [""] : []
content {
public_repository {
repository_base = split(" ", local.format_obj.remote.public_repository)[0]
repository_path = split(" ", local.format_obj.remote.public_repository)[1]
}
# dynamic "custom_repository" {
# for_each = local.format_obj.remote.custom_repository != null ? [""] : []
# content {
# uri = local.format_obj.remote.custom_repository
# }
# }
}
}
}
}
dynamic "virtual_repository_config" {
for_each = local.mode_string == "virtual" ? [""] : []
content {
dynamic "upstream_policies" {
for_each = local.format_obj.virtual
content {
id = upstream_policies.key
repository = lookup(
local.ctx.artifact_registries,
upstream_policies.value.repository,
upstream_policies.value.repository
)
priority = upstream_policies.value.priority
}
}
}
}
lifecycle {
precondition {
condition = local.mode_string != "remote" || contains(
["apt", "docker", "maven", "npm", "python", "yum"], local.format_string
)
error_message = "Invalid format for remote repository."
}
}
}
resource "google_tags_location_tag_binding" "binding" {
for_each = var.tag_bindings
parent = "//artifactregistry.googleapis.com/${google_artifact_registry_repository.registry.id}"
location = local.location
tag_value = templatestring(local._tag_bindings[each.key], var.context.tag_vars)
}