ca7e437d60
A persistent diff was occurring for Docker artifact registries where `immutable_tags` was set to `false`. On every `terraform plan`, Terraform would propose changing `immutable_tags` from `false` to `null`. This was caused by the `for_each` condition in the `docker_config` dynamic block, which only created the block if `immutable_tags` was explicitly set to `true`. The condition has been updated to check if `immutable_tags` is not null (`!= null`) instead of checking if it is true (`== true`). This ensures the `docker_config` block is correctly generated for both `true` and `false` values, aligning the configuration with the resource's state and eliminating the persistent diff. Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
227 lines
8.0 KiB
HCL
227 lines
8.0 KiB
HCL
/**
|
|
* Copyright 2025 Google LLC
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
locals {
|
|
format_obj = one([for k, v in var.format : v if v != null])
|
|
format_string = one([for k, v in var.format : k if v != null])
|
|
mode_string = one([for k, v in local.format_obj : k if v != null && v != false])
|
|
}
|
|
|
|
resource "google_artifact_registry_repository" "registry" {
|
|
provider = google-beta
|
|
project = var.project_id
|
|
location = var.location
|
|
description = var.description
|
|
format = upper(local.format_string)
|
|
labels = var.labels
|
|
repository_id = var.name
|
|
mode = "${upper(local.mode_string)}_REPOSITORY"
|
|
kms_key_name = var.encryption_key
|
|
cleanup_policy_dry_run = var.cleanup_policy_dry_run
|
|
|
|
vulnerability_scanning_config {
|
|
enablement_config = (
|
|
var.enable_vulnerability_scanning == true
|
|
? "INHERITED"
|
|
: var.enable_vulnerability_scanning == false ? "DISABLED" : null
|
|
)
|
|
}
|
|
|
|
dynamic "cleanup_policies" {
|
|
for_each = var.cleanup_policies == null ? {} : var.cleanup_policies
|
|
content {
|
|
id = cleanup_policies.key
|
|
action = cleanup_policies.value.action
|
|
|
|
dynamic "condition" {
|
|
for_each = (cleanup_policies.value.condition != null) ? [""] : []
|
|
content {
|
|
tag_state = cleanup_policies.value.condition.tag_state
|
|
tag_prefixes = cleanup_policies.value.condition.tag_prefixes
|
|
version_name_prefixes = cleanup_policies.value.condition.version_name_prefixes
|
|
package_name_prefixes = cleanup_policies.value.condition.package_name_prefixes
|
|
newer_than = cleanup_policies.value.condition.newer_than
|
|
older_than = cleanup_policies.value.condition.older_than
|
|
}
|
|
}
|
|
|
|
dynamic "most_recent_versions" {
|
|
for_each = (cleanup_policies.value.most_recent_versions != null) ? [""] : []
|
|
content {
|
|
package_name_prefixes = cleanup_policies.value.most_recent_versions.package_name_prefixes
|
|
keep_count = cleanup_policies.value.most_recent_versions.keep_count
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
dynamic "docker_config" {
|
|
# TODO: open a bug on the provider for this permadiff
|
|
for_each = (
|
|
local.format_string == "docker" && try(local.format_obj.standard.immutable_tags, null) != null
|
|
? [""] : []
|
|
)
|
|
content {
|
|
immutable_tags = local.format_obj.standard.immutable_tags
|
|
}
|
|
}
|
|
|
|
dynamic "maven_config" {
|
|
for_each = local.format_string == "maven" ? [""] : []
|
|
content {
|
|
allow_snapshot_overwrites = try(local.format_obj.standard.allow_snapshot_overwrites, null)
|
|
version_policy = try(local.format_obj.standard.version_policy, null)
|
|
}
|
|
}
|
|
|
|
dynamic "remote_repository_config" {
|
|
for_each = local.mode_string == "remote" ? [""] : []
|
|
content {
|
|
disable_upstream_validation = local.format_obj.remote.disable_upstream_validation
|
|
dynamic "upstream_credentials" {
|
|
for_each = local.format_obj.remote.upstream_credentials != null ? [""] : []
|
|
content {
|
|
username_password_credentials {
|
|
username = local.format_obj.remote.upstream_credentials.username
|
|
password_secret_version = local.format_obj.remote.upstream_credentials.password_secret_version
|
|
}
|
|
}
|
|
}
|
|
dynamic "apt_repository" {
|
|
for_each = local.format_string == "apt" ? [""] : []
|
|
content {
|
|
public_repository {
|
|
repository_base = split(" ", local.format_obj.remote.public_repository)[0]
|
|
repository_path = split(" ", local.format_obj.remote.public_repository)[1]
|
|
}
|
|
# dynamic "custom_repository" {
|
|
# for_each = local.format_obj.remote.custom_repository != null ? [""] : []
|
|
# content {
|
|
# uri = local.format_obj.remote.custom_repository
|
|
# }
|
|
# }
|
|
}
|
|
}
|
|
dynamic "common_repository" {
|
|
for_each = (
|
|
local.format_string == "docker" && try(local.format_obj.remote.common_repository, null) != null
|
|
? [""] : []
|
|
)
|
|
content {
|
|
uri = local.format_obj.remote.common_repository
|
|
}
|
|
}
|
|
dynamic "docker_repository" {
|
|
for_each = (
|
|
local.format_string == "docker" && try(local.format_obj.remote.common_repository, null) == null
|
|
? [""] : []
|
|
)
|
|
content {
|
|
public_repository = local.format_obj.remote.public_repository
|
|
dynamic "custom_repository" {
|
|
for_each = local.format_obj.remote.custom_repository != null ? [""] : []
|
|
content {
|
|
uri = local.format_obj.remote.custom_repository
|
|
}
|
|
}
|
|
}
|
|
}
|
|
dynamic "maven_repository" {
|
|
for_each = local.format_string == "maven" ? [""] : []
|
|
content {
|
|
public_repository = local.format_obj.remote.public_repository
|
|
dynamic "custom_repository" {
|
|
for_each = local.format_obj.remote.custom_repository != null ? [""] : []
|
|
content {
|
|
uri = local.format_obj.remote.custom_repository
|
|
}
|
|
}
|
|
}
|
|
}
|
|
dynamic "npm_repository" {
|
|
for_each = local.format_string == "npm" ? [""] : []
|
|
content {
|
|
public_repository = local.format_obj.remote.public_repository
|
|
dynamic "custom_repository" {
|
|
for_each = local.format_obj.remote.custom_repository != null ? [""] : []
|
|
content {
|
|
uri = local.format_obj.remote.custom_repository
|
|
}
|
|
}
|
|
}
|
|
}
|
|
dynamic "python_repository" {
|
|
for_each = local.format_string == "python" ? [""] : []
|
|
content {
|
|
public_repository = local.format_obj.remote.public_repository
|
|
dynamic "custom_repository" {
|
|
for_each = local.format_obj.remote.custom_repository != null ? [""] : []
|
|
content {
|
|
uri = local.format_obj.remote.custom_repository
|
|
}
|
|
}
|
|
}
|
|
}
|
|
dynamic "yum_repository" {
|
|
for_each = local.format_string == "yum" ? [""] : []
|
|
content {
|
|
public_repository {
|
|
repository_base = split(" ", local.format_obj.remote.public_repository)[0]
|
|
repository_path = split(" ", local.format_obj.remote.public_repository)[1]
|
|
}
|
|
# dynamic "custom_repository" {
|
|
# for_each = local.format_obj.remote.custom_repository != null ? [""] : []
|
|
# content {
|
|
# uri = local.format_obj.remote.custom_repository
|
|
# }
|
|
# }
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
dynamic "virtual_repository_config" {
|
|
for_each = local.mode_string == "virtual" ? [""] : []
|
|
content {
|
|
dynamic "upstream_policies" {
|
|
for_each = local.format_obj.virtual
|
|
content {
|
|
id = upstream_policies.key
|
|
repository = upstream_policies.value.repository
|
|
priority = upstream_policies.value.priority
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
lifecycle {
|
|
precondition {
|
|
condition = local.mode_string != "remote" || contains(
|
|
["apt", "docker", "maven", "npm", "python", "yum"], local.format_string
|
|
)
|
|
error_message = "Invalid format for remote repository."
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
resource "google_tags_location_tag_binding" "binding" {
|
|
for_each = var.tag_bindings
|
|
parent = "//artifactregistry.googleapis.com/${google_artifact_registry_repository.registry.id}"
|
|
location = var.location
|
|
tag_value = each.value
|
|
}
|