Files
hunfabric/modules/project/main.tf
Julio Castillo 2eaa0d5e27 Add support for dynamic tags (#3897)
* Allow creation of dynamic tags

* Extend project factory and related modules to support dynamic values

* Extend folder and organization modules

* project and organization readme

* Simplify dynamic tag support and remove unnecessary restrictions

  • Schemas & Validations: Removed the restriction that forbade combining IAM fields with  allowed_values_regex  on tags. Updated validations in  project  and  organization  modules, and
  simplified all relevant JSON schemas.
  • Module Tag Bindings: Simplified the  tag_value  assignment in  folder ,  project ,  gcs ,  bigquery-dataset , and  kms  modules by removing the defensive  can(regex(...))  check and
  calling  templatestring  directly.
  • Outputs: Removed the  tags_dynamic  output from  project  and  organization  modules, as the same information is now available in  tag_keys .
  • Project Factory: Updated  tag_vars_projects  in  projects.tf  to use the native  namespaced_name  attribute and filtered manually for dynamic tags.

* fix(organization, project): fix linting and tests for dynamic tag support

- Align allowed_values_regex and description extraction in _tags_merged
  locals to use lookup() for consistency with other fields.
- Fix spacing in project context variable (alphabetical ordering).
- Update organization tags test to include the new cost_center tag key
  with allowed_values_regex.
- Update project tags test to include the new cost_center tag key and
  reflect the resolved allowed_values_regex on environment.

* refactor(gcs): refine tag bindings and fix context test

- Add _tag_bindings local to pre-resolve context references, enabling
  templatestring to receive a direct map reference (required by Terraform).
- Use var.context.tag_vars instead of the non-existent local.ctx.tag_vars.
- Fix HCL syntax in context.tfvars (escaped inner quotes).
- Update context test inventory to reflect 3 tag bindings including a
  dynamic value resolved via templatestring.

* refactor: align modules with tag binding context pattern

- Add _tag_bindings local + templatestring dance to cloud-run-v2,
  compute-vm, folder, kms modules (bigquery-dataset already had it)
- Exclude tag_vars from local.ctx in cloud-run-v2, compute-vm, folder,
  kms, project modules (bigquery-dataset already had it)
- Add tag_vars to context variable in cloud-run-v2, compute-vm modules
  (others already had it)
- Update all context tests with dynamic tag binding values using
  var.context.tag_vars

* docs: add module-level tftest.yaml test instructions to GEMINI.md

* docs: regenerate READMEs after tag-regex alignment

- Regenerate variable tables in 7 module READMEs to reflect
  line number shifts from prior tag-regex changes
- Add tag_vars exclusion to gcs ctx local
- Fix whitespace alignment in iam-service-account and
  project-factory tag_vars blocks
- Update tftest resource counts for organization and project
- Remove tags_dynamic from organization/project output tables

* fix(project-factory): update test inventory for tag_bindings module split

- Move tag binding address from folder-2 to folder-2-iam in test
  inventory (tag_bindings moved from creation to IAM modules)
- Update module instance count from 34 to 35
- Regenerate README tables after terraform fmt line shifts
- Apply terraform fmt to variables.tf

* refactor(project-factory): remove unnecessary depends_on from folder-iam modules

Folder IAM modules depend on their own folder creation modules, not
on module.projects. The explicit depends_on was leftover from an
earlier design.

* FAST stages

* Address review comments.

- FAST Stages:
  - Added tag_keys to output-files.tf in 0-org-setup to pass org tags via tfvars.
  - Sorted tag_keys and tag_values in output-files.tf.
  - Updated project-factory, networking, and security stages to use tag_keys.
  - Filtered tag_keys for dynamic tags only.
- Modules:
  - Excluded tag_vars from local.ctx in iam-service-account and organization.
  - Simplified tag_value in iam-service-account.
- Tests:
  - Updated test inventories for 0-org-setup and project-factory.

* Fix tf format

* Fix tfdoc

* docs: add ADR for templatestring vars convention and update status of base path ADR

* More tfdoc

* Update schemas

* Use endswith in context loop

* Address review

* Update FAST readmes

* Update last modules

* Terraform fmt

* Revert alloydb

* Fix whitespace

---------

Co-authored-by: Ludovico Magnocavallo <ludo@qix.it>
2026-04-24 20:45:45 +00:00

209 lines
7.0 KiB
HCL

/**
* Copyright 2025 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
locals {
# descriptive_name cannot contain colons, so we omit the universe from the default
_observability_factory_path = pathexpand(coalesce(
var.factories_config.observability, "-"
))
bigquery_reservations_assigments = {
for reservation_name, reservation in google_bigquery_reservation.default :
reservation_name => {
(reservation.location) = {
for job_type in distinct([
for a in values(google_bigquery_reservation_assignment.default) : a.job_type
if a.reservation == reservation.id
]) : job_type => [
for a in values(google_bigquery_reservation_assignment.default) : a.assignee
if a.reservation == reservation.id && a.job_type == job_type
]
}
}
}
ctx = {
for k, v in var.context : k => {
for kk, vv in v : "${local.ctx_p}${k}:${kk}" => vv
} if !endswith(k, "_vars")
}
ctx_p = "$"
descriptive_name = (
var.descriptive_name != null ? var.descriptive_name : "${local.prefix}${var.name}"
)
observability_factory_data_raw = [
for f in try(fileset(local._observability_factory_path, "*.yaml"), []) :
yamldecode(file("${local._observability_factory_path}/${f}"))
]
parent_type = (
var.parent == null
? null
: (
startswith(var.parent, "organizations")
? "organizations"
: "folders"
)
)
parent_id = (
var.parent == null || startswith(coalesce(var.parent, "-"), "$")
? var.parent
: split("/", var.parent)[1]
)
prefix = var.prefix == null ? "" : "${var.prefix}-"
project = (
var.project_reuse == null
? {
project_id = try(google_project.project[0].project_id, null)
number = try(google_project.project[0].number, null)
name = try(google_project.project[0].name, null)
}
: (
try(var.project_reuse.use_data_source, null) == false
? {
project_id = local.project_id
number = try(var.project_reuse.attributes.number, null)
name = try(var.project_reuse.attributes.name, null)
}
: {
project_id = local.project_id
number = try(data.google_project.project[0].number, null)
name = try(data.google_project.project[0].name, null)
}
)
)
project_id = (
strcontains("${local.prefix}${var.name}", ":")
? "${local.prefix}${var.name}"
: "${local.universe_prefix}${local.prefix}${var.name}"
)
universe_prefix = var.universe == null ? "" : "${var.universe.prefix}:"
# available services are those declared, minus any unsupported by universe
_available_services = setsubtract(
var.services,
try(var.universe.unavailable_services, [])
)
available_services = tolist(setsubtract(
local._available_services,
["orgpolicy.googleapis.com"]
))
enable_orgpolicy_service = contains(local._available_services, "orgpolicy.googleapis.com")
}
moved {
from = google_project_service.project_services["orgpolicy.googleapis.com"]
to = google_project_service.org_policy_service[0]
}
data "google_project" "project" {
count = try(var.project_reuse.use_data_source, null) == true ? 1 : 0
project_id = local.project_id
}
resource "google_project" "project" {
count = var.project_reuse == null ? 1 : 0
org_id = local.parent_type == "organizations" ? local.parent_id : null
folder_id = (
local.parent_type == "folders"
? lookup(local.ctx.folder_ids, local.parent_id, local.parent_id)
: null
)
project_id = local.project_id
name = local.descriptive_name
billing_account = var.billing_account
auto_create_network = var.auto_create_network
labels = var.labels
deletion_policy = var.deletion_policy
lifecycle {
precondition {
condition = var.skip_delete == null
error_message = "skip_delete is deprecated. Use deletion_policy."
}
}
}
resource "google_project_service" "project_services" {
for_each = toset(local.available_services)
project = local.project.project_id
service = each.value
disable_on_destroy = var.service_config.disable_on_destroy
disable_dependent_services = var.service_config.disable_dependent_services
depends_on = [google_org_policy_policy.default]
}
resource "google_project_service" "org_policy_service" {
count = local.enable_orgpolicy_service ? 1 : 0
project = local.project.project_id
service = "orgpolicy.googleapis.com"
disable_on_destroy = var.service_config.disable_on_destroy
disable_dependent_services = var.service_config.disable_dependent_services
}
resource "google_compute_project_metadata_item" "default" {
for_each = (
contains(local.available_services, "compute.googleapis.com") ? var.compute_metadata : {}
)
project = local.project.project_id
key = each.key
value = each.value
depends_on = [google_project_service.project_services]
}
resource "google_resource_manager_lien" "lien" {
count = var.lien_reason != null ? 1 : 0
parent = "projects/${local.project.number}"
restrictions = ["resourcemanager.projects.delete"]
origin = "created-by-terraform"
reason = var.lien_reason
}
resource "google_kms_key_handle" "default" {
for_each = var.kms_autokeys
project = local.project.project_id
name = each.key
location = try(
local.ctx.locations[each.value.location], each.value.location
)
resource_type_selector = each.value.resource_type_selector
}
resource "google_essential_contacts_contact" "contact" {
provider = google-beta
for_each = var.contacts
parent = "projects/${local.project.project_id}"
email = lookup(
local.ctx.email_addresses, each.key, each.key
)
language_tag = "en"
notification_category_subscriptions = each.value
depends_on = [
google_project_iam_binding.authoritative,
google_project_iam_binding.bindings,
google_project_iam_member.bindings
]
}
resource "google_monitoring_monitored_project" "primary" {
provider = google-beta
for_each = toset(var.metric_scopes)
metrics_scope = lookup(local.ctx.project_ids, each.value, each.value)
name = local.project.project_id
}
resource "google_compute_project_default_network_tier" "default_network_tier" {
count = var.default_network_tier == null ? 0 : 1
network_tier = var.default_network_tier
project = local.project.project_id
}