* Allow creation of dynamic tags * Extend project factory and related modules to support dynamic values * Extend folder and organization modules * project and organization readme * Simplify dynamic tag support and remove unnecessary restrictions • Schemas & Validations: Removed the restriction that forbade combining IAM fields with allowed_values_regex on tags. Updated validations in project and organization modules, and simplified all relevant JSON schemas. • Module Tag Bindings: Simplified the tag_value assignment in folder , project , gcs , bigquery-dataset , and kms modules by removing the defensive can(regex(...)) check and calling templatestring directly. • Outputs: Removed the tags_dynamic output from project and organization modules, as the same information is now available in tag_keys . • Project Factory: Updated tag_vars_projects in projects.tf to use the native namespaced_name attribute and filtered manually for dynamic tags. * fix(organization, project): fix linting and tests for dynamic tag support - Align allowed_values_regex and description extraction in _tags_merged locals to use lookup() for consistency with other fields. - Fix spacing in project context variable (alphabetical ordering). - Update organization tags test to include the new cost_center tag key with allowed_values_regex. - Update project tags test to include the new cost_center tag key and reflect the resolved allowed_values_regex on environment. * refactor(gcs): refine tag bindings and fix context test - Add _tag_bindings local to pre-resolve context references, enabling templatestring to receive a direct map reference (required by Terraform). - Use var.context.tag_vars instead of the non-existent local.ctx.tag_vars. - Fix HCL syntax in context.tfvars (escaped inner quotes). - Update context test inventory to reflect 3 tag bindings including a dynamic value resolved via templatestring. * refactor: align modules with tag binding context pattern - Add _tag_bindings local + templatestring dance to cloud-run-v2, compute-vm, folder, kms modules (bigquery-dataset already had it) - Exclude tag_vars from local.ctx in cloud-run-v2, compute-vm, folder, kms, project modules (bigquery-dataset already had it) - Add tag_vars to context variable in cloud-run-v2, compute-vm modules (others already had it) - Update all context tests with dynamic tag binding values using var.context.tag_vars * docs: add module-level tftest.yaml test instructions to GEMINI.md * docs: regenerate READMEs after tag-regex alignment - Regenerate variable tables in 7 module READMEs to reflect line number shifts from prior tag-regex changes - Add tag_vars exclusion to gcs ctx local - Fix whitespace alignment in iam-service-account and project-factory tag_vars blocks - Update tftest resource counts for organization and project - Remove tags_dynamic from organization/project output tables * fix(project-factory): update test inventory for tag_bindings module split - Move tag binding address from folder-2 to folder-2-iam in test inventory (tag_bindings moved from creation to IAM modules) - Update module instance count from 34 to 35 - Regenerate README tables after terraform fmt line shifts - Apply terraform fmt to variables.tf * refactor(project-factory): remove unnecessary depends_on from folder-iam modules Folder IAM modules depend on their own folder creation modules, not on module.projects. The explicit depends_on was leftover from an earlier design. * FAST stages * Address review comments. - FAST Stages: - Added tag_keys to output-files.tf in 0-org-setup to pass org tags via tfvars. - Sorted tag_keys and tag_values in output-files.tf. - Updated project-factory, networking, and security stages to use tag_keys. - Filtered tag_keys for dynamic tags only. - Modules: - Excluded tag_vars from local.ctx in iam-service-account and organization. - Simplified tag_value in iam-service-account. - Tests: - Updated test inventories for 0-org-setup and project-factory. * Fix tf format * Fix tfdoc * docs: add ADR for templatestring vars convention and update status of base path ADR * More tfdoc * Update schemas * Use endswith in context loop * Address review * Update FAST readmes * Update last modules * Terraform fmt * Revert alloydb * Fix whitespace --------- Co-authored-by: Ludovico Magnocavallo <ludo@qix.it>
136 lines
4.4 KiB
HCL
136 lines
4.4 KiB
HCL
/**
|
|
* Copyright 2024 Google LLC
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
locals {
|
|
_region = join("-", slice(split("-", local.zone), 0, 2))
|
|
advanced_mf = anytrue([
|
|
for k, v in var.machine_features_config : v != null
|
|
])
|
|
ctx = {
|
|
for k, v in var.context : k => {
|
|
for kk, vv in v : "${local.ctx_p}${k}:${kk}" => vv
|
|
} if !endswith(k, "_vars")
|
|
}
|
|
ctx_kms_keys = merge(local.ctx.kms_keys, {
|
|
for k, v in google_kms_key_handle.default :
|
|
"$kms_keys:autokeys/${k}" => v.kms_key
|
|
})
|
|
ctx_p = "$"
|
|
gpu = var.gpu != null
|
|
on_host_maintenance = coalesce(
|
|
var.scheduling_config.on_host_maintenance,
|
|
(
|
|
var.scheduling_config.provisioning_model == "SPOT" ||
|
|
var.confidential_compute != null ||
|
|
local.gpu
|
|
) ? "TERMINATE" : "MIGRATE"
|
|
)
|
|
project_id = lookup(local.ctx.project_ids, var.project_id, var.project_id)
|
|
region = lookup(local.ctx.locations, local._region, local._region)
|
|
service_account = var.service_account == null ? null : {
|
|
email = (var.service_account.auto_create
|
|
? google_service_account.service_account[0].email
|
|
: try(
|
|
local.ctx.iam_principals[var.service_account.email],
|
|
var.service_account.email
|
|
)
|
|
)
|
|
scopes = (
|
|
var.service_account.scopes != null ? var.service_account.scopes : (
|
|
var.service_account.email == null && !var.service_account.auto_create
|
|
# default scopes for Compute default SA
|
|
? [
|
|
"https://www.googleapis.com/auth/devstorage.read_only",
|
|
"https://www.googleapis.com/auth/logging.write",
|
|
"https://www.googleapis.com/auth/monitoring.write"
|
|
]
|
|
# default scopes for own SA
|
|
: [
|
|
"https://www.googleapis.com/auth/cloud-platform",
|
|
"https://www.googleapis.com/auth/userinfo.email"
|
|
]
|
|
)
|
|
)
|
|
}
|
|
termination_action = (
|
|
var.scheduling_config.provisioning_model == "SPOT" || var.scheduling_config.max_run_duration != null
|
|
? coalesce(var.scheduling_config.termination_action, "STOP")
|
|
: null
|
|
)
|
|
zone = lookup(local.ctx.locations, var.zone, var.zone)
|
|
}
|
|
|
|
resource "google_kms_key_handle" "default" {
|
|
for_each = var.kms_autokeys
|
|
project = local.project_id
|
|
name = each.key
|
|
location = coalesce(
|
|
try(local.ctx.locations[each.value.location], null),
|
|
each.value.location,
|
|
local.region
|
|
)
|
|
resource_type_selector = each.value.resource_type_selector
|
|
}
|
|
|
|
resource "google_compute_instance_iam_binding" "default" {
|
|
project = local.project_id
|
|
for_each = var.iam
|
|
zone = local.zone
|
|
instance_name = var.name
|
|
role = lookup(local.ctx.custom_roles, each.key, each.key)
|
|
members = [
|
|
for m in each.value : lookup(local.ctx.iam_principals, m, m)
|
|
]
|
|
depends_on = [google_compute_instance.default]
|
|
}
|
|
|
|
resource "google_compute_instance_group" "unmanaged" {
|
|
count = try(var.group.membership, null) == null && var.group != null && !local.is_template ? 1 : 0
|
|
project = local.project_id
|
|
network = (
|
|
length(var.network_interfaces) > 0
|
|
? var.network_interfaces[0].network
|
|
: ""
|
|
)
|
|
zone = local.zone
|
|
name = var.name
|
|
description = var.description
|
|
instances = [google_compute_instance.default[0].self_link]
|
|
dynamic "named_port" {
|
|
for_each = var.group.named_ports != null ? var.group.named_ports : {}
|
|
iterator = config
|
|
content {
|
|
name = config.key
|
|
port = config.value
|
|
}
|
|
}
|
|
}
|
|
|
|
resource "google_compute_instance_group_membership" "unmanaged" {
|
|
count = try(var.group.membership, null) != null && !local.is_template ? 1 : 0
|
|
project = local.project_id
|
|
zone = local.zone
|
|
instance = google_compute_instance.default[0].self_link
|
|
instance_group = var.group.membership
|
|
}
|
|
|
|
resource "google_service_account" "service_account" {
|
|
count = try(var.service_account.auto_create, null) == true ? 1 : 0
|
|
project = local.project_id
|
|
account_id = "tf-vm-${var.name}"
|
|
display_name = "Terraform VM ${var.name}."
|
|
}
|