Commit Graph

36 Commits

Author SHA1 Message Date
Julio Castillo
2eaa0d5e27 Add support for dynamic tags (#3897)
* Allow creation of dynamic tags

* Extend project factory and related modules to support dynamic values

* Extend folder and organization modules

* project and organization readme

* Simplify dynamic tag support and remove unnecessary restrictions

  • Schemas & Validations: Removed the restriction that forbade combining IAM fields with  allowed_values_regex  on tags. Updated validations in  project  and  organization  modules, and
  simplified all relevant JSON schemas.
  • Module Tag Bindings: Simplified the  tag_value  assignment in  folder ,  project ,  gcs ,  bigquery-dataset , and  kms  modules by removing the defensive  can(regex(...))  check and
  calling  templatestring  directly.
  • Outputs: Removed the  tags_dynamic  output from  project  and  organization  modules, as the same information is now available in  tag_keys .
  • Project Factory: Updated  tag_vars_projects  in  projects.tf  to use the native  namespaced_name  attribute and filtered manually for dynamic tags.

* fix(organization, project): fix linting and tests for dynamic tag support

- Align allowed_values_regex and description extraction in _tags_merged
  locals to use lookup() for consistency with other fields.
- Fix spacing in project context variable (alphabetical ordering).
- Update organization tags test to include the new cost_center tag key
  with allowed_values_regex.
- Update project tags test to include the new cost_center tag key and
  reflect the resolved allowed_values_regex on environment.

* refactor(gcs): refine tag bindings and fix context test

- Add _tag_bindings local to pre-resolve context references, enabling
  templatestring to receive a direct map reference (required by Terraform).
- Use var.context.tag_vars instead of the non-existent local.ctx.tag_vars.
- Fix HCL syntax in context.tfvars (escaped inner quotes).
- Update context test inventory to reflect 3 tag bindings including a
  dynamic value resolved via templatestring.

* refactor: align modules with tag binding context pattern

- Add _tag_bindings local + templatestring dance to cloud-run-v2,
  compute-vm, folder, kms modules (bigquery-dataset already had it)
- Exclude tag_vars from local.ctx in cloud-run-v2, compute-vm, folder,
  kms, project modules (bigquery-dataset already had it)
- Add tag_vars to context variable in cloud-run-v2, compute-vm modules
  (others already had it)
- Update all context tests with dynamic tag binding values using
  var.context.tag_vars

* docs: add module-level tftest.yaml test instructions to GEMINI.md

* docs: regenerate READMEs after tag-regex alignment

- Regenerate variable tables in 7 module READMEs to reflect
  line number shifts from prior tag-regex changes
- Add tag_vars exclusion to gcs ctx local
- Fix whitespace alignment in iam-service-account and
  project-factory tag_vars blocks
- Update tftest resource counts for organization and project
- Remove tags_dynamic from organization/project output tables

* fix(project-factory): update test inventory for tag_bindings module split

- Move tag binding address from folder-2 to folder-2-iam in test
  inventory (tag_bindings moved from creation to IAM modules)
- Update module instance count from 34 to 35
- Regenerate README tables after terraform fmt line shifts
- Apply terraform fmt to variables.tf

* refactor(project-factory): remove unnecessary depends_on from folder-iam modules

Folder IAM modules depend on their own folder creation modules, not
on module.projects. The explicit depends_on was leftover from an
earlier design.

* FAST stages

* Address review comments.

- FAST Stages:
  - Added tag_keys to output-files.tf in 0-org-setup to pass org tags via tfvars.
  - Sorted tag_keys and tag_values in output-files.tf.
  - Updated project-factory, networking, and security stages to use tag_keys.
  - Filtered tag_keys for dynamic tags only.
- Modules:
  - Excluded tag_vars from local.ctx in iam-service-account and organization.
  - Simplified tag_value in iam-service-account.
- Tests:
  - Updated test inventories for 0-org-setup and project-factory.

* Fix tf format

* Fix tfdoc

* docs: add ADR for templatestring vars convention and update status of base path ADR

* More tfdoc

* Update schemas

* Use endswith in context loop

* Address review

* Update FAST readmes

* Update last modules

* Terraform fmt

* Revert alloydb

* Fix whitespace

---------

Co-authored-by: Ludovico Magnocavallo <ludo@qix.it>
2026-04-24 20:45:45 +00:00
Wiktor Niesiobędzki
2e42c1b548 service_account_config for Cloud Run v2
Additional changes:
* align vpc-connector interface to Cloud Functions
* split managed and unmanaged resources into separate files, this makes
  easier to introduce further changes
* add support for contexts
* move `vpc_connector` variable to variables.tf for Cloud Functions
* remove `create` from `vpc_connector` in Cloud Functions as it was
  sharing the meaning with `vpc_connector_create`
2025-10-27 08:03:53 +01:00
Wiktor Niesiobędzki
b20d62815a Fix Cloud Run validation for refactored fields (#3295)
Co-authored-by: Julio Castillo <jccb@google.com>
2025-09-03 13:13:15 +02:00
Julio Castillo
d3f0dc984e Upgrade provider to version 7.0.1 (#3291)
* Upgrade provider to version 7.0.1

* Update READMEs

* Bring back depends_on for services and jobs
2025-09-01 17:29:20 +02:00
Wiktor Niesiobędzki
a106688b0e Fix references to service_account 2025-08-13 22:11:07 +02:00
Wiktor Niesiobędzki
75fa484730 Remove support for creating SA for event arc triggers 2025-08-13 22:11:07 +02:00
Wiktor Niesiobędzki
e498f3407e Add support for GPUs in Cloud Run 2025-08-13 15:21:27 +02:00
Wiktor Niesiobędzki
b5cc01c598 Add Cloud Run Worker Pools
Refactor jobs and services parameters into separte variables
Remove prefix (not needed, namespace is local to the project)
2025-08-12 19:59:50 +02:00
Muhammad Elsaeed
9bd4363269 feat: add GCS bucket trigger support for Cloud Run services (#3257)
* feat: add GCS bucket trigger support for Cloud Run services 🌟

* feat: add examples for Cloud Run service with Eventarc storage triggers

* fix: update bucket name in Eventarc storage trigger example and clean up service account configuration

---------

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
2025-08-01 16:41:49 +00:00
Maciej Sikora
b062a8b521 Update modules/cloud-run-v2/variables.tf
Co-authored-by: Wiktor Niesiobędzki <github@vink.pl>
2025-06-18 12:28:54 +02:00
Maciej Sikora
1dd4873a02 fixes validation 2025-06-18 12:28:54 +02:00
Maciej Sikora
1d8e48f9e4 Apply suggestions from code review
Co-authored-by: Wiktor Niesiobędzki <github@vink.pl>
2025-06-18 12:28:54 +02:00
Maciej Sikora
461c0b8e44 adds iap configuration test 2025-06-18 12:28:54 +02:00
Maciej Sikora
d2e9c238f6 ensures tf < 1.2 compatibility 2025-06-18 12:28:54 +02:00
Maciej Sikora
9dcd0c86ab ensures tf < 1.2 compatibility 2025-06-18 12:28:54 +02:00
Maciej Sikora
fd8f659a3a docs && fmt 2025-06-18 12:28:54 +02:00
Maciej Sikora
1cc50e30ae simplifies iap configuration 2025-06-18 12:28:54 +02:00
Maciej Sikora
c0bac5acc0 feat: adds support for direct cloud run iap 2025-06-18 12:28:54 +02:00
Maciej Sikora
ae5c12a2a3 adds revision label (#3117)
* adds revision label

* adds revision label
2025-05-28 18:32:06 +02:00
Charles Salmon
ee468514b0 [cloud-run-v2] Add ability to deploy OpenTelemetry Collector sidecar (#3071)
* [cloud-run-v2] Add ability to deploy OpenTelemetry Collector sidecar

- Adds `depends_on` flag to container definition
- Adds `port` to HTTP liveness & startup probes

* fix: add port to unmanaged resource's startup & liveness probes

* fix: add copyright boilerplate

* Fix README

---------

Co-authored-by: Julio Castillo <jccb@google.com>
2025-05-08 09:05:58 +00:00
Luca Prete
763b917b78 [cloud-run-v2] Add ability to control code deployments outside Terraform 2025-04-29 10:32:57 +02:00
Tim Hiatt
762841da79 Fr/timhiatt/invoker iam disable (#2994)
* Staging the New Variable change and the flag endablement for 'invoker_iam_disabled' in the 'google_cloud_run_v2_service' resouece associated with the 'cloud-run-v2' module.

* Updating tfdocs to include the new variables for the 'invoker_iam_disabled' flag in the 'google_cloud_run_v2_service' resource in module 'cloud-run-v2'

* Updating the testing in the readme for the cloud-run-v2 module.

* Fixing an issue with links in README.md Docs

* Fixing README.md linting.
2025-04-01 11:41:08 +02:00
Wiktor Niesiobędzki
9f7505d061 Allow providing network for Direct VPC access 2024-11-18 10:25:19 +01:00
Ludovico Magnocavallo
601f137c9b Fix ipv6 output in net-vpc module, add support for extra volumes in cloud run v2 module (#2638)
* fix #2637

* fix #2635
2024-10-24 08:36:20 +02:00
Ludovico Magnocavallo
bbe84a5ca8 add extra job revision attributes (#2608) 2024-10-07 11:45:59 +02:00
Simone Ruffilli
7f8a02a405 Add support for google provider 6.x (#2536)
* Add support for google provider 6.x

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>
Co-authored-by: Julio Castillo <jccb@google.com>
2024-09-05 10:35:58 +00:00
apichick
110318a51d Cloud run v2 custom audiences (#2476)
* Added forward_proxy_uri to apigee environments in apigee-x-foundations blueprint

* Added custom audiences to Cloud Run v2 module
2024-08-07 08:54:36 +02:00
Ludovico Magnocavallo
c80af8de66 Extend support for tag bindings to more modules (#2307)
* fix kms tag bindings

* bigquery dataset

* fix bigquery

* cloud run

* normalize variable type

* rename gcs heading

* kms example test

* fix bigquery

* fix cloud run

* cloud run v2
2024-05-25 10:42:45 +02:00
Saleh Elnagar
136d74db4e add cmek option for cloud_run_v2 (#2177)
add cmek option for cloud_run_v2 service and job
2024-03-27 09:15:02 +00:00
Wiktor Niesiobędzki
bee3072568 Add support for Cloud Run v2 jobs (#1954)
Add support for Cloud Run v2 jobs

* create a separate file for service creation (service.tf) and job
  (job.tf) - for easy comparison
* add E2E tests where possibile
* remove default value for input variable `region`
* fix subnet range VPC Access Connector example
* add creation of service account for audit logs call (trigger requires
  service account)
* use provided trigger service account email in
  `local.trigger_sa_email`, so explicitly provided SA is passed to
  trigger
* set default value for vpc_connector_create.throughput.max, to match
  what is set by GCP API, as provider uses wrong default of 300 which
  results in perma-diff
* create inventory fiels for all examples

Global changes
* (tests) add input variable `project_number`, to allow assigning IAM permissions to Service Accounts in fixtures
* (tests) fix not outputting the path, when object is not found in inventory
* (tests) fix `create_e2e_sandbox.sh` - now it properly finds root of the repo

Secret Manager
* added `version_versions` output, to allow specifying versions in other modules. `versions` is sensitive and it makes it unsuitable for `for_each` values

New test fixtures
* `pubsub.tf` - creating one topic
* `secret-credential.tf` - creating Secret Manager `credential` secret
* `shared-vpc.tf` - creating two projects (host and service), and vpc in host project
* `vpc-connector.tf` - creating VPC Access Connector instance
2024-02-18 14:57:34 +01:00
Wiktor Niesiobędzki
526185fd1f Remove default region for Cloud Function and Cloud Run (#2004)
Remove default region for Cloud Function and Cloud Run
2024-01-24 10:23:40 +00:00
Julio Diez
88b91cdaee Move VPC connector management to specific files 2023-12-18 11:53:28 +01:00
Julio Diez
4c9243017c Rename attribute secret.secret to secret.name 2023-12-18 11:42:57 +01:00
Julio Diez
bc4f89d9dc Remove 'traffic' variable, the module is not intended to manage rollouts 2023-12-18 11:39:28 +01:00
Julio Diez
c599717856 Refactor the interface 2023-12-14 08:44:51 +01:00
Julio Diez
4c80442f53 First version of Cloud Run module v2 2023-12-04 20:20:46 +01:00