Fix health checks in net-ilb and compute-mig modules (#69)

* fix health checks in ilb module

* fix health check in compute-mig and add basic tests

tests/modules/compute_mig/__init__.py

@@ -0,0 +1,13 @@
+# Copyright 2020 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.

tests/modules/compute_mig/fixture/main.tf

@@ -0,0 +1,33 @@
+/**
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+module "test" {
+  source      = "../../../../modules/compute-mig"
+  project_id  = "my-project"
+  location    = "europe-west1"
+  name        = "test-mig"
+  target_size = 2
+  default_version = {
+    instance_template = "foo-template"
+    name              = "foo"
+  }
+  autoscaler_config   = var.autoscaler_config
+  health_check_config = var.health_check_config
+  named_ports         = var.named_ports
+  regional            = var.regional
+  update_policy       = var.update_policy
+  versions            = var.versions
+}

tests/modules/compute_mig/fixture/variables.tf

@@ -0,0 +1,83 @@
+/**
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+variable "autoscaler_config" {
+  type = object({
+    max_replicas                      = number
+    min_replicas                      = number
+    cooldown_period                   = number
+    cpu_utilization_target            = number
+    load_balancing_utilization_target = number
+    metric = object({
+      name                       = string
+      single_instance_assignment = number
+      target                     = number
+      type                       = string # GAUGE, DELTA_PER_SECOND, DELTA_PER_MINUTE
+      filter                     = string
+    })
+  })
+  default = null
+}
+
+variable "auto_healing_policies" {
+  type = object({
+    health_check      = string
+    initial_delay_sec = number
+  })
+  default = null
+}
+
+variable "health_check_config" {
+  type = object({
+    type    = string      # http https tcp ssl http2
+    check   = map(any)    # actual health check block attributes
+    config  = map(number) # interval, thresholds, timeout
+    logging = bool
+  })
+  default = null
+}
+
+variable "named_ports" {
+  type    = map(number)
+  default = null
+}
+
+variable "regional" {
+  type    = bool
+  default = false
+}
+
+variable "update_policy" {
+  type = object({
+    type                 = string # OPPORTUNISTIC | PROACTIVE
+    minimal_action       = string # REPLACE | RESTART
+    min_ready_sec        = number
+    max_surge_type       = string # fixed | percent
+    max_surge            = number
+    max_unavailable_type = string
+    max_unavailable      = number
+  })
+  default = null
+}
+
+variable "versions" {
+  type = map(object({
+    instance_template = string
+    target_type       = string # fixed | percent
+    target_size       = number
+  }))
+  default = null
+}

tests/modules/compute_mig/test_plan.py

@@ -0,0 +1,73 @@
+# Copyright 2020 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+import os
+import pytest
+
+
+FIXTURES_DIR = os.path.join(os.path.dirname(__file__), 'fixture')
+
+
+def test_defaults(plan_runner):
+  "Test variable defaults."
+  _, resources = plan_runner(FIXTURES_DIR)
+  assert len(resources) == 1
+  mig = resources[0]
+  assert mig['type'] == 'google_compute_instance_group_manager'
+  assert mig['values']['target_size'] == 2
+  assert mig['values']['zone']
+  _, resources = plan_runner(FIXTURES_DIR, regional='true')
+  assert len(resources) == 1
+  mig = resources[0]
+  assert mig['type'] == 'google_compute_region_instance_group_manager'
+  assert mig['values']['target_size'] == 2
+  assert mig['values']['region']
+
+
+def test_health_check(plan_runner):
+  "Test health check resource."
+  health_check_config = '{type="tcp", check={port=80}, config=null, logging=false}'
+  _, resources = plan_runner(
+      FIXTURES_DIR, health_check_config=health_check_config)
+  assert len(resources) == 2
+  assert any(r['type'] == 'google_compute_health_check' for r in resources)
+
+
+def test_autoscaler(plan_runner):
+  "Test autoscaler resource."
+  autoscaler_config = (
+      '{'
+      'max_replicas=3, min_replicas=1, cooldown_period=60,'
+      'cpu_utilization_target=65, load_balancing_utilization_target=null,'
+      'metric=null'
+      '}'
+  )
+  _, resources = plan_runner(FIXTURES_DIR, autoscaler_config=autoscaler_config)
+  assert len(resources) == 2
+  autoscaler = resources[0]
+  assert autoscaler['type'] == 'google_compute_autoscaler'
+  assert autoscaler['values']['autoscaling_policy'] == [{
+      'cooldown_period': 60,
+      'cpu_utilization': [{'target': 65}],
+      'load_balancing_utilization': [],
+      'max_replicas': 3,
+      'metric': [],
+      'min_replicas': 1
+  }]
+  _, resources = plan_runner(
+      FIXTURES_DIR, autoscaler_config=autoscaler_config, regional='true')
+  assert len(resources) == 2
+  autoscaler = resources[0]
+  assert autoscaler['type'] == 'google_compute_region_autoscaler'