diff --git a/examples/data-solutions/dp-foundation/06-common.tf b/examples/data-solutions/dp-foundation/06-common.tf index 9cfdc7a50..5c88bccbb 100644 --- a/examples/data-solutions/dp-foundation/06-common.tf +++ b/examples/data-solutions/dp-foundation/06-common.tf @@ -48,6 +48,7 @@ module "cmn-prj" { iam_additive = var.project_create == null ? local.iam_cmn : {} group_iam = local.group_iam_cmn services = concat(var.project_services, [ + "datacatalog.googleapis.com", "dlp.googleapis.com", ]) } @@ -55,9 +56,9 @@ module "cmn-prj" { # Uncomment this section and assigne key links accondingly in local. variable # if you want to create KMS keys in the common projet -# module "sec-kms-0" { +# module "cmn-kms-0" { # source = "../../../modules/kms" -# project_id = module.sec-prj.project_id +# project_id = module.cmn-prj.project_id # keyring = { # name = "${var.prefix}-kr-global", # location = var.location_config.region @@ -67,9 +68,9 @@ module "cmn-prj" { # } # } -# module "sec-kms-1" { +# module "cmn-kms-1" { # source = "../../../modules/kms" -# project_id = module.sec-prj.project_id +# project_id = module.cmn-prj.project_id # keyring = { # name = "${var.prefix}-kr-mregional", # location = var.location_config.region @@ -80,9 +81,9 @@ module "cmn-prj" { # } # } -# module "sec-kms-2" { +# module "cmn-kms-2" { # source = "../../../modules/kms" -# project_id = module.sec-prj.project_id +# project_id = module.cmn-prj.project_id # keyring = { # name = "${var.prefix}-kr-regional", # location = var.location_config.region diff --git a/examples/data-solutions/dp-foundation/README.md b/examples/data-solutions/dp-foundation/README.md index 9a2b17629..1e68878ed 100644 --- a/examples/data-solutions/dp-foundation/README.md +++ b/examples/data-solutions/dp-foundation/README.md @@ -168,7 +168,7 @@ For a more fine grained configuration, check variables on [`variables.tf`](./var ## Customizations ### Create Cloud Key Management keys as part of the DP -To create Cloud Key Management keys in the DP you can uncomment the Cloud Key Management resources configured in the [`06-sec-main.tf`](./06-sec-main.tf) file and update Cloud Key Management keys pointers on `local.service_encryption_keys.*` to the local resource created. +To create Cloud Key Management keys in the DP you can uncomment the Cloud Key Management resources configured in the [`06-common.tf`](./06-common.tf) file and update Cloud Key Management keys pointers on `local.service_encryption_keys.*` to the local resource created. ### Assign roles at BQ Dataset level To handle multiple groups of `data-analysts` accessing the same Data Lake layer projects but only to the dataset belonging to a specific group, you may want to assign roles at BigQuery dataset level instead of at project-level. diff --git a/examples/data-solutions/dp-foundation/images/overview_diagram.png b/examples/data-solutions/dp-foundation/images/overview_diagram.png index 4fe42c015..b1a0f7887 100644 Binary files a/examples/data-solutions/dp-foundation/images/overview_diagram.png and b/examples/data-solutions/dp-foundation/images/overview_diagram.png differ