From 3a2d6e1b46b138b0dd097cd4b91c35fea100aa37 Mon Sep 17 00:00:00 2001 From: Ludovico Magnocavallo Date: Wed, 1 Mar 2023 08:08:07 +0100 Subject: [PATCH 1/2] Fix secondary ranges in net-vpc readme (#1198) Fixes #1197 --- modules/net-vpc/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/net-vpc/README.md b/modules/net-vpc/README.md index bd5675d23..25dfaa58f 100644 --- a/modules/net-vpc/README.md +++ b/modules/net-vpc/README.md @@ -174,7 +174,7 @@ module "vpc-host" { ip_cidr_range = "10.0.0.0/24" name = "subnet-1" region = "europe-west1" - secondary_ip_range = { + secondary_ip_ranges = { pods = "172.16.0.0/20" services = "192.168.0.0/24" } From 67bc391b66286072dcccd6c036d2bf67d6a2e551 Mon Sep 17 00:00:00 2001 From: Julio Castillo Date: Wed, 1 Mar 2023 09:58:50 +0100 Subject: [PATCH 2/2] Add test for #1197 --- tests/modules/net_vpc/examples/shared-vpc.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/modules/net_vpc/examples/shared-vpc.yaml b/tests/modules/net_vpc/examples/shared-vpc.yaml index b004e3151..6467fd389 100644 --- a/tests/modules/net_vpc/examples/shared-vpc.yaml +++ b/tests/modules/net_vpc/examples/shared-vpc.yaml @@ -24,7 +24,12 @@ values: module.vpc-host.google_compute_shared_vpc_service_project.service_projects["project2"]: host_project: my-project service_project: project2 - module.vpc-host.google_compute_subnetwork.subnetwork["europe-west1/subnet-1"]: {} + module.vpc-host.google_compute_subnetwork.subnetwork["europe-west1/subnet-1"]: + secondary_ip_range: + - ip_cidr_range: 172.16.0.0/20 + range_name: pods + - ip_cidr_range: 192.168.0.0/24 + range_name: services module.vpc-host.google_compute_subnetwork_iam_binding.binding["europe-west1/subnet-1.roles/compute.networkUser"]: condition: [] members: