From aab282bf19cc0786f990c683ae60620f85f66697 Mon Sep 17 00:00:00 2001
From: Daniel Strebel <strebel@google.com>
Date: Wed, 19 Feb 2025 18:16:05 +0100
Subject: [PATCH] feat: adding generated_id for backends to net-lb-app-ext
 (#2913)

---
 modules/net-lb-app-ext/README.md            | 21 +++++++++++----------
 modules/net-lb-app-ext/outputs.tf           |  7 +++++++
 tests/modules/net_lb_app_ext/test-plan.yaml |  1 +
 3 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/modules/net-lb-app-ext/README.md b/modules/net-lb-app-ext/README.md
index 541fcc3a6..21a22c64d 100644
--- a/modules/net-lb-app-ext/README.md
+++ b/modules/net-lb-app-ext/README.md
@@ -1077,16 +1077,17 @@ After provisioning this change, and verifying that the new certificate is provis
 | name | description | sensitive |
 |---|---|:---:|
 | [address](outputs.tf#L17) | Forwarding rule addresses. |  |
-| [backend_service_ids](outputs.tf#L25) | Backend service resources. |  |
-| [backend_service_names](outputs.tf#L32) | Backend service resource names. |  |
-| [forwarding_rules](outputs.tf#L39) | Forwarding rule resource. |  |
-| [global_neg_ids](outputs.tf#L44) | Autogenerated global network endpoint group ids. |  |
-| [group_ids](outputs.tf#L51) | Autogenerated instance group ids. |  |
-| [health_check_ids](outputs.tf#L58) | Autogenerated health check ids. |  |
-| [ids](outputs.tf#L65) | Fully qualified forwarding rule ids. |  |
-| [neg_ids](outputs.tf#L72) | Autogenerated network endpoint group ids. |  |
-| [psc_neg_ids](outputs.tf#L79) | Autogenerated PSC network endpoint group ids. |  |
-| [serverless_neg_ids](outputs.tf#L86) | Autogenerated serverless network endpoint group ids. |  |
+| [backend_service_generated_ids](outputs.tf#L25) | Generated Ids for backend service resources. |  |
+| [backend_service_ids](outputs.tf#L32) | Backend service resources. |  |
+| [backend_service_names](outputs.tf#L39) | Backend service resource names. |  |
+| [forwarding_rules](outputs.tf#L46) | Forwarding rule resource. |  |
+| [global_neg_ids](outputs.tf#L51) | Autogenerated global network endpoint group ids. |  |
+| [group_ids](outputs.tf#L58) | Autogenerated instance group ids. |  |
+| [health_check_ids](outputs.tf#L65) | Autogenerated health check ids. |  |
+| [ids](outputs.tf#L72) | Fully qualified forwarding rule ids. |  |
+| [neg_ids](outputs.tf#L79) | Autogenerated network endpoint group ids. |  |
+| [psc_neg_ids](outputs.tf#L86) | Autogenerated PSC network endpoint group ids. |  |
+| [serverless_neg_ids](outputs.tf#L93) | Autogenerated serverless network endpoint group ids. |  |
 
 ## Fixtures
 
diff --git a/modules/net-lb-app-ext/outputs.tf b/modules/net-lb-app-ext/outputs.tf
index 9739a08ed..0f1f31020 100644
--- a/modules/net-lb-app-ext/outputs.tf
+++ b/modules/net-lb-app-ext/outputs.tf
@@ -22,6 +22,13 @@ output "address" {
   }
 }
 
+output "backend_service_generated_ids" {
+  description = "Generated Ids for backend service resources."
+  value = {
+    for k, v in google_compute_backend_service.default : k => v.generated_id
+  }
+}
+
 output "backend_service_ids" {
   description = "Backend service resources."
   value = {
diff --git a/tests/modules/net_lb_app_ext/test-plan.yaml b/tests/modules/net_lb_app_ext/test-plan.yaml
index 232209d39..d285c331d 100644
--- a/tests/modules/net_lb_app_ext/test-plan.yaml
+++ b/tests/modules/net_lb_app_ext/test-plan.yaml
@@ -28,6 +28,7 @@ counts:
 outputs:
   address: __missing__
   backend_service_ids: __missing__
+  backend_service_generated_ids: __missing__
   forwarding_rules: __missing__
   group_ids: __missing__
   health_check_ids: __missing__