From 987ea34d93023b4d5baed5cd160d7b016558482e Mon Sep 17 00:00:00 2001 From: Ludovico Magnocavallo Date: Sun, 26 Mar 2023 18:39:07 +0200 Subject: [PATCH] DNS policy module fixes (#1278) * dns response policy module * tfdoc * Add dns policy tests * fix copyright, var description, initial wording --------- Co-authored-by: Julio Castillo --- modules/dns-response-policy/README.md | 4 ++-- modules/dns-response-policy/outputs.tf | 2 +- modules/dns-response-policy/variables.tf | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/dns-response-policy/README.md b/modules/dns-response-policy/README.md index fe788d6d8..dddf4aba5 100644 --- a/modules/dns-response-policy/README.md +++ b/modules/dns-response-policy/README.md @@ -1,6 +1,6 @@ # Google Cloud DNS Response Policy -This module allows management of a [Google Cloud DNS policy and its rules](https://cloud.google.com/dns/docs/zones/manage-response-policies). The policy can be already existing and passed in via its id. +This module allows management of a [Google Cloud DNS policy and its rules](https://cloud.google.com/dns/docs/zones/manage-response-policies). The policy can already exist and be referenced by name by setting the `policy_create` variable to `false`. ## Examples @@ -73,7 +73,7 @@ module "dns-policy" { | name | description | type | required | default | |---|---|:---:|:---:|:---:| -| [name](variables.tf#L30) | Zone name, must be unique within the project. | string | ✓ | | +| [name](variables.tf#L30) | Policy name. | string | ✓ | | | [project_id](variables.tf#L49) | Project id for the zone. | string | ✓ | | | [clusters](variables.tf#L17) | Map of GKE clusters to which this policy is applied in name => id format. | map(string) | | {} | | [description](variables.tf#L24) | Policy description. | string | | "Terraform managed." | diff --git a/modules/dns-response-policy/outputs.tf b/modules/dns-response-policy/outputs.tf index 0a266e709..1b6f76bc9 100644 --- a/modules/dns-response-policy/outputs.tf +++ b/modules/dns-response-policy/outputs.tf @@ -1,5 +1,5 @@ /** - * Copyright 2022 Google LLC + * Copyright 2023 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/modules/dns-response-policy/variables.tf b/modules/dns-response-policy/variables.tf index 0d91254be..8f37ec2b3 100644 --- a/modules/dns-response-policy/variables.tf +++ b/modules/dns-response-policy/variables.tf @@ -1,5 +1,5 @@ /** - * Copyright 2022 Google LLC + * Copyright 2023 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -28,7 +28,7 @@ variable "description" { } variable "name" { - description = "Zone name, must be unique within the project." + description = "Policy name." type = string }