kovagoadi/hunfabric
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix regression in compute-vm module (#3872)

Browse Source 
* fix(compute-vm): purge key_revocation_action_type from tests and update schema link

* fix schema link
This commit is contained in:
Ludovico Magnocavallo
2026-04-15 19:17:42 +02:00
committed by GitHub
parent 11dba441f9
commit 8076220648
17 changed files with 12 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fast/project-templates/devops-azure-wif/project.yaml
View File

@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
# yaml-language-server: $schema=https://cdn.jsdelivr.net/gh/GoogleCloudPlatform/cloud-foundation-fabric@fast-dev/modules/project-factory/schemas/project.schema.json # yaml-language-server: $schema=https://cdn.jsdelivr.net/gh/GoogleCloudPlatform/cloud-foundation-fabric@master/modules/project-factory/schemas/project.schema.json
# TODO: set a parent folder if needed # TODO: set a parent folder if needed
# parent: $folder_ids:shared # parent: $folder_ids:shared

2
modules/compute-vm/variables.tf
View File

@@ -285,7 +285,7 @@ variable "lifecycle_config" {
type = object({ type = object({
allow_stopping_for_update = optional(bool, true) allow_stopping_for_update = optional(bool, true)
deletion_protection = optional(bool, false) deletion_protection = optional(bool, false)
key_revocation_action_type = optional(string, "NONE") key_revocation_action_type = optional(string)
graceful_shutdown = optional(object({ graceful_shutdown = optional(object({
enabled = optional(bool, false) enabled = optional(bool, false)
max_duration_secs = optional(number) max_duration_secs = optional(number)

2
tests/modules/compute_mig/examples/flexible.yaml
View File

@@ -72,7 +72,7 @@ values:
enable_display: null enable_display: null
guest_accelerator: [] guest_accelerator: []
instance_description: null instance_description: null
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: metadata:

1
tests/modules/compute_vm/context-template-regional.yaml
View File

@@ -66,7 +66,6 @@ values:
enable_display: null enable_display: null
guest_accelerator: [] guest_accelerator: []
instance_description: null instance_description: null
key_revocation_action_type: NONE
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

1
tests/modules/compute_vm/context-template.yaml
View File

@@ -66,7 +66,6 @@ values:
enable_display: null enable_display: null
guest_accelerator: [] guest_accelerator: []
instance_description: null instance_description: null
key_revocation_action_type: NONE
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

1
tests/modules/compute_vm/context-vm.yaml
View File

@@ -88,7 +88,6 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

1
tests/modules/compute_vm/examples/disk-hyperdisk-arm.yaml
View File

@@ -130,7 +130,6 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE
labels: null labels: null
machine_type: c4a-standard-1 machine_type: c4a-standard-1
metadata: null metadata: null

1
tests/modules/compute_vm/examples/disk-hyperdisk-cust-performance.yaml
View File

@@ -128,7 +128,6 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE
labels: null labels: null
machine_type: n4-standard-2 machine_type: n4-standard-2
metadata: null metadata: null

1
tests/modules/compute_vm/examples/disk-hyperdisk-pool.yaml
View File

@@ -165,7 +165,6 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE
labels: null labels: null
machine_type: c4d-standard-2 machine_type: c4d-standard-2
metadata: null metadata: null

1
tests/modules/compute_vm/examples/disks-example-template.yaml
View File

@@ -52,7 +52,6 @@ values:
enable_display: null enable_display: null
guest_accelerator: [] guest_accelerator: []
instance_description: null instance_description: null
key_revocation_action_type: NONE
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

1
tests/modules/compute_vm/examples/snapshot-schedule-create.yaml
View File

@@ -55,7 +55,6 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

4
tests/modules/net_lb_app_ext/examples/http-https-redirect.yaml
View File

@@ -57,7 +57,7 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null
@@ -143,7 +143,7 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

4
tests/modules/net_lb_app_ext/examples/tls-settings.yaml
View File

@@ -43,7 +43,7 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null
@@ -130,7 +130,7 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

4
tests/modules/net_lb_app_ext_regional/examples/tls-settings.yaml
View File

@@ -43,7 +43,7 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null
@@ -130,7 +130,7 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

2
tests/modules/net_vpn_dynamic/examples/vpn-single-tunnel-custom-ciphers.yaml
View File

@@ -43,7 +43,7 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

2
tests/modules/net_vpn_dynamic/examples/vpn-single-tunnel.yaml
View File

@@ -43,7 +43,7 @@ values:
enable_display: false enable_display: false
hostname: null hostname: null
instance_encryption_key: [] instance_encryption_key: []
key_revocation_action_type: NONE key_revocation_action_type: null
labels: null labels: null
machine_type: e2-micro machine_type: e2-micro
metadata: null metadata: null

2
tools/update_schema_links.py
View File

@@ -39,7 +39,7 @@ def get_yaml_files(folder):
@click.argument('folder', type=click.Path(exists=True, file_okay=False)) @click.argument('folder', type=click.Path(exists=True, file_okay=False))
@click.option( @click.option(
'--format', default= '--format', default=
'https://cdn.jsdelivr.net/gh/GoogleCloudPlatform/cloud-foundation-fabric@fast-dev/fast/stages/{parent}/schemas/', 'https://cdn.jsdelivr.net/gh/GoogleCloudPlatform/cloud-foundation-fabric@master/fast/stages/{parent}/schemas/',
help='Format string for the new schema path. Use {parent} placeholder. ' help='Format string for the new schema path. Use {parent} placeholder. '
'Example: https://example.com/{parent}/schemas') 'Example: https://example.com/{parent}/schemas')
@click.option('--dry-run', is_flag=True, default=False, @click.option('--dry-run', is_flag=True, default=False,