Remove firewall policy management from resource management modules (#1581)

* rename firewall policy module, fix outputs

* add TOC to firewall policy module

* don't depend policy on parent id

* remove firewall policy from resource management modules

* remove factory conditionals

* fast net a and b

* fast stages

* fast tfdoc

* fast tfdoc

* remove unused test

* fix shielded folder blueprint

* fix shielded folder blueprint

tests/modules/organization/firewall_policies_factory_combined.tfvars

@@ -1,51 +0,0 @@
-firewall_policies = {
-  policy1 = {
-    allow-ingress = {
-      description = ""
-      direction   = "INGRESS"
-      action      = "allow"
-      priority    = 100
-      ranges      = ["10.0.0.0/8"]
-      ports = {
-        tcp = ["22"]
-      }
-      target_service_accounts = null
-      target_resources        = null
-      logging                 = false
-    }
-    deny-egress = {
-      description = ""
-      direction   = "EGRESS"
-      action      = "deny"
-      priority    = 200
-      ranges      = ["192.168.0.0/24"]
-      ports = {
-        tcp = ["443"]
-      }
-      target_service_accounts = null
-      target_resources        = null
-      logging                 = false
-    }
-  }
-  policy2 = {
-    allow-ingress = {
-      description = ""
-      direction   = "INGRESS"
-      action      = "allow"
-      priority    = 100
-      ranges      = ["10.0.0.0/8"]
-      ports = {
-        tcp = ["22"]
-      }
-      target_service_accounts = null
-      target_resources        = null
-      logging                 = false
-    }
-  }
-}
-
-firewall_policy_factory = {
-  cidr_file   = "../../tests/modules/organization/data/firewall-cidrs.yaml"
-  policy_name = "factory-1"
-  rules_file  = "../../tests/modules/organization/data/firewall-rules.yaml"
-}

tests/modules/organization/firewall_policies_factory_combined.yaml

@@ -1,27 +0,0 @@
-# Copyright 2022 Google LLC
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#      http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-values:
-  google_compute_firewall_policy.policy["factory-1"]: {}
-  google_compute_firewall_policy.policy["policy1"]: {}
-  google_compute_firewall_policy.policy["policy2"]: {}
-  google_compute_firewall_policy_rule.rule["factory-1-allow-admins"]: {}
-  google_compute_firewall_policy_rule.rule["factory-1-allow-ssh-from-iap"]: {}
-  google_compute_firewall_policy_rule.rule["policy1-allow-ingress"]: {}
-  google_compute_firewall_policy_rule.rule["policy1-deny-egress"]: {}
-  google_compute_firewall_policy_rule.rule["policy2-allow-ingress"]: {}
-
-counts:
-  google_compute_firewall_policy: 3
-  google_compute_firewall_policy_rule: 5

tests/modules/organization/tftest.yaml

@@ -21,5 +21,4 @@ tests:
   org_policies_list:
   org_policies_boolean:
   org_policies_custom_constraints:
-  firewall_policies_factory_combined:
   tags: