Recreate subscription of topic replacement, fix tests

tests/modules/pubsub/context.yaml

@@ -37,7 +37,6 @@ values:
     - group:test-group@example.com
     project: foo-logging-0
     role: organizations/366118655033/roles/myRoleOne
-    topic: my-topic
 
 counts:
   google_pubsub_topic: 1

tests/modules/pubsub/examples/bigquery-subscription-with-service-account.yaml

@@ -39,7 +39,6 @@ values:
     push_config: []
     retain_acked_messages: false
     retry_policy: []
-    topic: my-topic
   module.pubsub.google_pubsub_topic.default:
     ingestion_data_source_settings: []
     kms_key_name: null

tests/modules/pubsub/examples/bigquery-subscription.yaml

@@ -21,7 +21,6 @@ values:
       write_metadata: false
     name: test-bigquery
     project: project-id
-    topic: my-topic
   module.pubsub.google_pubsub_topic.default:
     name: my-topic
     project: project-id

tests/modules/pubsub/examples/cloud-storage-subscription.yaml

@@ -35,7 +35,6 @@ values:
     retain_acked_messages: false
     retry_policy: []
     timeouts: null
-    topic: my-topic
   module.pubsub.google_pubsub_topic.default:
     kms_key_name: null
     labels: null

tests/modules/pubsub/examples/push-subscription.yaml

@@ -33,7 +33,6 @@ values:
     retain_acked_messages: false
     retry_policy: []
     timeouts: null
-    topic: my-topic
   module.pubsub.google_pubsub_topic.default:
     kms_key_name: null
     labels: null

tests/modules/pubsub/examples/simple.yaml

@@ -26,14 +26,12 @@ values:
     - serviceAccount:sa1@sa.example
     project: project-id
     role: roles/pubsub.subscriber
-    topic: my-topic
   module.pubsub.google_pubsub_topic_iam_binding.authoritative["roles/pubsub.viewer"]:
     condition: []
     members:
     - group:organization-admins@example.org
     project: project-id
     role: roles/pubsub.viewer
-    topic: my-topic
 
 counts:
   google_pubsub_topic: 1

tests/modules/pubsub/examples/subscription-iam.yaml

@@ -29,14 +29,12 @@ values:
     retain_acked_messages: false
     retry_policy: []
     timeouts: null
-    topic: my-topic
   module.pubsub.google_pubsub_subscription_iam_binding.authoritative["test-1.roles/pubsub.subscriber"]:
     condition: []
     members:
     - serviceAccount:sa1@sa.example
     project: project-id
     role: roles/pubsub.subscriber
-    subscription: test-1
   module.pubsub.google_pubsub_topic.default:
     kms_key_name: null
     labels: null

tests/modules/pubsub/examples/subscriptions.yaml

@@ -29,7 +29,6 @@ values:
     retain_acked_messages: false
     retry_policy: []
     timeouts: null
-    topic: my-topic
   module.pubsub.google_pubsub_subscription.default["test-pull-override"]:
     bigquery_config: []
     cloud_storage_config: []
@@ -50,7 +49,6 @@ values:
     terraform_labels:
       test: override
     timeouts: null
-    topic: my-topic
   module.pubsub.google_pubsub_topic.default:
     kms_key_name: null
     labels: