From 5be136e2ea96e6fdb9be8329e7c8883515821827 Mon Sep 17 00:00:00 2001
From: Simone Ruffilli <ilruffo@gmail.com>
Date: Thu, 16 Oct 2025 14:37:07 +0200
Subject: [PATCH] Always use local.project_id in net-vpc

---
 modules/net-vpc/main.tf    | 4 ++--
 modules/net-vpc/outputs.tf | 2 +-
 modules/net-vpc/psa.tf     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/modules/net-vpc/main.tf b/modules/net-vpc/main.tf
index 446505cb5..5248c941a 100644
--- a/modules/net-vpc/main.tf
+++ b/modules/net-vpc/main.tf
@@ -37,14 +37,14 @@ locals {
       ? {
         id = format(
           "projects/%s/global/networks/%s",
-          var.project_id,
+          local.project_id,
           var.name
         )
         name       = var.name
         network_id = try(var.vpc_reuse.attributes.network_id, null)
         self_link = format(
           "https://www.googleapis.com/compute/v1/projects/%s/global/networks/%s",
-          var.project_id,
+          local.project_id,
           var.name
         )
       }
diff --git a/modules/net-vpc/outputs.tf b/modules/net-vpc/outputs.tf
index 29213238a..bcb4c27da 100644
--- a/modules/net-vpc/outputs.tf
+++ b/modules/net-vpc/outputs.tf
@@ -94,7 +94,7 @@ output "network_id" {
 
 output "project_id" {
   description = "Project ID containing the network. Use this when you need to create resources *after* the VPC is fully set up (e.g. subnets created, shared VPC service projects attached, Private Service Networking configured)."
-  value       = var.project_id
+  value       = local.project_id
   depends_on = [
     google_compute_subnetwork.subnetwork,
     google_compute_network_peering.local,
diff --git a/modules/net-vpc/psa.tf b/modules/net-vpc/psa.tf
index 8b9855896..1fb234f50 100644
--- a/modules/net-vpc/psa.tf
+++ b/modules/net-vpc/psa.tf
@@ -74,7 +74,7 @@ resource "google_service_networking_connection" "psa_connection" {
 
 resource "google_compute_network_peering_routes_config" "psa_routes" {
   for_each = local.psa_configs
-  project  = var.project_id
+  project  = local.project_id
   peering = (
     google_service_networking_connection.psa_connection[each.key].peering
   )
@@ -85,7 +85,7 @@ resource "google_compute_network_peering_routes_config" "psa_routes" {
 
 resource "google_service_networking_peered_dns_domain" "name" {
   for_each   = local.psa_peered_domains
-  project    = var.project_id
+  project    = local.project_id
   network    = local.network.name
   name       = each.key
   dns_suffix = each.value.dns_suffix