From 4e7b44e184c8c1134cd50286f6a554144873cf07 Mon Sep 17 00:00:00 2001 From: Julio Castillo Date: Tue, 10 Feb 2026 14:42:21 +0100 Subject: [PATCH] Retry #3719 and fix broken link (#3723) * Fix url and remove unavailable service * Add inline depedencies to `tools/check_links.py` --- fast/stages/0-org-setup/README-GCD.md | 7 +++---- .../datasets/classic-gcd/projects/core/billing-0.yaml | 4 ++-- tools/check_links.py | 11 ++++++++++- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/fast/stages/0-org-setup/README-GCD.md b/fast/stages/0-org-setup/README-GCD.md index b7af7fc11..0dfbc3e5e 100644 --- a/fast/stages/0-org-setup/README-GCD.md +++ b/fast/stages/0-org-setup/README-GCD.md @@ -132,12 +132,12 @@ provider "google-beta" { ### Defaults Configuration (`defaults.yaml`) -Update your `defaults.yaml` file to include a `universe` block within the `overrides` section. This configures the correct API domains and disables service identities that are not available in GCD. +Update your `defaults.yaml` file to include a `universe` block within the `overrides` section. This configures the correct API domains and disables service identities that are not available in GCD. Additionally, you must provide valid values for the following fields in the context section: -* `context.email_addresses.gcp-organization-admins`: used to set the [essential contact]([url](https://docs.cloud.google.com/resource-manager/docs/manage-essential-contacts)) for the core projects +* `context.email_addresses.gcp-organization-admins`: used to set the [essential contact](https://docs.cloud.google.com/resource-manager/docs/manage-essential-contacts) for the core projects * `context.iam_principals.gcp-organization-admins`: Used to grant administrative permissions to the administrators. - + **Note on Principals:** If you use a group for the admin principal, ensure your user identity is a member of that group. Otherwise, set this field to your own user identity (e.g., `principal://iam.googleapis.com/locations/global/workforcePools/...`) instead of a group. For further details, refer to the [Configure defaults](./README.md#configure-defaults) section in the standard README. Your `defaults.yaml should` contain sections that look like this: @@ -277,4 +277,3 @@ Once the **Organization Setup** stage is fully deployed: ``` 2. **Proceed to Next Stages:** Continue with the subsequent FAST stages (VPC-SC, Security, Networking, Project Factory). The universe configuration established here is automatically propagated to these stages via the FAST cross-stage output mechanism. - diff --git a/fast/stages/0-org-setup/datasets/classic-gcd/projects/core/billing-0.yaml b/fast/stages/0-org-setup/datasets/classic-gcd/projects/core/billing-0.yaml index 29070bbc2..65db76843 100644 --- a/fast/stages/0-org-setup/datasets/classic-gcd/projects/core/billing-0.yaml +++ b/fast/stages/0-org-setup/datasets/classic-gcd/projects/core/billing-0.yaml @@ -1,4 +1,4 @@ -# Copyright 2025 Google LLC +# Copyright 2026 Google LLC # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -22,7 +22,7 @@ iam_by_principals: - roles/owner services: - bigquery.googleapis.com - - bigquerydatatransfer.googleapis.com + # - bigquerydatatransfer.googleapis.com - storage.googleapis.com datasets: billing_export: diff --git a/tools/check_links.py b/tools/check_links.py index a6ce48a30..d9624a5b3 100755 --- a/tools/check_links.py +++ b/tools/check_links.py @@ -1,6 +1,6 @@ #!/usr/bin/env python3 -# Copyright 2023 Google LLC +# Copyright 2026 Google LLC # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -13,6 +13,15 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. +# +# /// script +# requires-python = ">=3.11" +# dependencies = [ +# "click", +# "marko", +# "requests", +# ] +# /// '''Recursively check link destination validity in Markdown files. This tool recursively checks that local links in Markdown files point to valid