Align network stage defaults/outputs to other stages, add defaults schema (#3481)

* networking stage

* implement defaults for vpc defaults :)

* Rename peering test to simple

This enables tflint on 2-networking stage

* tflint

* bring peering test back

* bring peering test back

* yaml lint

---------

Co-authored-by: Wiktor Niesiobędzki <wiktorn@google.com>

tests/fast/stages/s2_networking/ncc.tfvars

@@ -32,6 +32,9 @@ service_accounts = {
   "iac-0/iac-pf-rw" = "iac-pf-rw@test.iam.gserviceaccount.com"
   "iac-0/iac-pf-ro" = "iac-pf-ro@test.iam.gserviceaccount.com"
 }
+storage_buckets = {
+  "iac-0/iac-outputs" = "test"
+}
 tag_values = {
   "environment/development" = "tagValues/12345"
   "environment/production"  = "tagValues/12346"

tests/fast/stages/s2_networking/ncc.yaml

@@ -123,7 +123,7 @@ values:
     terraform_labels:
       goog-terraform-provisioned: "true"
     timeouts: null
-  google_storage_bucket_object.tfvars["1"]:
+  google_storage_bucket_object.tfvars[0]:
     bucket: test
     cache_control: null
     content_disposition: null
@@ -141,7 +141,7 @@ values:
     source_md5hash: null
     temporary_hold: null
     timeouts: null
-  google_storage_bucket_object.version["1"]:
+  google_storage_bucket_object.version[0]:
     bucket: test
     cache_control: null
     content_disposition: null

tests/fast/stages/s2_networking/nva.tfvars

@@ -32,6 +32,9 @@ service_accounts = {
   "iac-0/iac-pf-rw" = "iac-pf-rw@test.iam.gserviceaccount.com"
   "iac-0/iac-pf-ro" = "iac-pf-ro@test.iam.gserviceaccount.com"
 }
+storage_buckets = {
+  "iac-0/iac-outputs" = "test"
+}
 tag_values = {
   "environment/development" = "tagValues/12345"
   "environment/production"  = "tagValues/12346"

tests/fast/stages/s2_networking/simple.tfvars

@@ -32,6 +32,9 @@ service_accounts = {
   "iac-0/iac-pf-rw" = "iac-pf-rw@test.iam.gserviceaccount.com"
   "iac-0/iac-pf-ro" = "iac-pf-ro@test.iam.gserviceaccount.com"
 }
+storage_buckets = {
+  "iac-0/iac-outputs" = "test"
+}
 tag_values = {
   "environment/development" = "tagValues/12345"
   "environment/production"  = "tagValues/12346"

tests/fast/stages/s2_networking/simple.yaml

@@ -77,7 +77,7 @@ values:
     project: fast-prod-net-core-0
     region: europe-west8
     timeouts: null
-  google_storage_bucket_object.tfvars["1"]:
+  google_storage_bucket_object.tfvars[0]:
     bucket: test
     cache_control: null
     content_disposition: null
@@ -95,7 +95,7 @@ values:
     source_md5hash: null
     temporary_hold: null
     timeouts: null
-  google_storage_bucket_object.version["1"]:
+  google_storage_bucket_object.version[0]:
     bucket: test
     cache_control: null
     content_disposition: null

tests/fast/stages/s2_networking/tftest.yaml

@@ -15,7 +15,8 @@
 module: fast/stages/2-networking
 
 tests:
-  peerings:
+  # peering is renamed to simple so as to trigger tflint
+  simple:
   ncc:
   nva:
   vpns:

tests/fast/stages/s2_networking/vpns.tfvars

@@ -32,6 +32,9 @@ service_accounts = {
   "iac-0/iac-pf-rw" = "iac-pf-rw@test.iam.gserviceaccount.com"
   "iac-0/iac-pf-ro" = "iac-pf-ro@test.iam.gserviceaccount.com"
 }
+storage_buckets = {
+  "iac-0/iac-outputs" = "test"
+}
 tag_values = {
   "environment/development" = "tagValues/12345"
   "environment/production"  = "tagValues/12346"

tests/fast/stages/s2_networking/vpns.yaml

@@ -131,7 +131,7 @@ values:
     project: fast-prod-net-prod-0
     region: europe-west8
     timeouts: null
-  google_storage_bucket_object.tfvars["1"]:
+  google_storage_bucket_object.tfvars[0]:
     bucket: test
     cache_control: null
     content_disposition: null
@@ -149,7 +149,7 @@ values:
     source_md5hash: null
     temporary_hold: null
     timeouts: null
-  google_storage_bucket_object.version["1"]:
+  google_storage_bucket_object.version[0]:
     bucket: test
     cache_control: null
     content_disposition: null