Add tflint to pipelines (#2220)

* Fix terraform_deprecated_index

https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_index.md

* Fix terraform_deprecated_interpolation

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

* Fix more indexing

* Remove unused variable

* Enable TFLint for modules

* Add tflint config file

* Fix chdir

* Lint modules

* TFLint fixes

* TFLint

* Fixes binauthz README

* Fixes DNS response policy tests. Restores MIG outputs.

* Fixes other DNS response policy tests.

* Update tests for fast 2-e

* Moar fixed tests

---------

Co-authored-by: Simone Ruffilli <sruffilli@google.com>
This commit is contained in:
Julio Castillo
2024-04-17 11:23:48 +03:00
committed by GitHub
parent 25bf17c837
commit 3af7e257d2
180 changed files with 2341 additions and 2317 deletions

View File

@@ -1,5 +1,5 @@
/**
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -19,7 +19,7 @@ locals {
additional_cluster_configs = merge(
[for pcc_name, pcc in var.vmw_private_cloud_configs
: { for cluster_name, cluster in pcc.additional_cluster_configs
: "${cluster_name}" => merge(
: (cluster_name) => merge(
cluster,
{ parent = try(google_vmwareengine_private_cloud.vmw_engine_private_clouds[pcc_name].id, null) }
)
@@ -27,8 +27,8 @@ locals {
]...)
vmw_network = (
var.vmw_network_config.create
? try(google_vmwareengine_network.private_cloud_network.0, null)
: try(data.google_vmwareengine_network.private_cloud_network.0, null)
? try(google_vmwareengine_network.private_cloud_network[0], null)
: try(data.google_vmwareengine_network.private_cloud_network[0], null)
)
}

View File

@@ -36,5 +36,5 @@ output "vmw_engine_private_clouds" {
output "vmw_private_cloud_network" {
description = "VMware engine network."
value = google_vmwareengine_network.private_cloud_network.0
value = google_vmwareengine_network.private_cloud_network[0]
}