kovagoadi/hunfabric
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add tflint to pipelines (#2220)

Browse Source 
* Fix terraform_deprecated_index

https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_index.md

* Fix terraform_deprecated_interpolation

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

* Fix more indexing

* Remove unused variable

* Enable TFLint for modules

* Add tflint config file

* Fix chdir

* Lint modules

* TFLint fixes

* TFLint

* Fixes binauthz README

* Fixes DNS response policy tests. Restores MIG outputs.

* Fixes other DNS response policy tests.

* Update tests for fast 2-e

* Moar fixed tests

---------

Co-authored-by: Simone Ruffilli <sruffilli@google.com>
This commit is contained in:
Julio Castillo
2024-04-17 11:23:48 +03:00
committed by GitHub
parent 25bf17c837
commit 3af7e257d2
180 changed files with 2341 additions and 2317 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
modules/compute-mig/autoscaler.tf
View File

@@ -17,7 +17,6 @@
# tfdoc:file:description Autoscaler resource.
locals {
as_enabled = true
as_scaling = try(var.autoscaler_config.scaling_control, null)
as_signals = try(var.autoscaler_config.scaling_signals, null)
}
@@ -29,7 +28,7 @@ resource "google_compute_autoscaler" "default" {
name = var.name
zone = var.location
description = var.description
target = google_compute_instance_group_manager.default.0.id
target = google_compute_instance_group_manager.default[0].id
autoscaling_policy {
max_replicas = var.autoscaler_config.max_replicas
@@ -133,7 +132,7 @@ resource "google_compute_region_autoscaler" "default" {
name = var.name
region = var.location
description = var.description
target = google_compute_region_instance_group_manager.default.0.id
target = google_compute_region_instance_group_manager.default[0].id
autoscaling_policy {
max_replicas = var.autoscaler_config.max_replicas

7
modules/compute-mig/main.tf
View File

@@ -17,14 +17,9 @@
locals {
health_check = (
try(var.auto_healing_policies.health_check, null) == null
? try(google_compute_health_check.default.0.self_link, null)
? try(google_compute_health_check.default[0].self_link, null)
: try(var.auto_healing_policies.health_check, null)
)
instance_group_manager = (
local.is_regional ?
google_compute_region_instance_group_manager.default :
google_compute_instance_group_manager.default
)
is_regional = length(split("-", var.location)) == 2
}

14
modules/compute-mig/outputs.tf
View File

@@ -17,8 +17,8 @@
output "autoscaler" {
description = "Auto-created autoscaler resource."
value = var.autoscaler_config == null ? null : try(
google_compute_autoscaler.default.0,
google_compute_region_autoscaler.default.0,
google_compute_autoscaler.default[0],
google_compute_region_autoscaler.default[0],
{}
)
}
@@ -26,8 +26,8 @@ output "autoscaler" {
output "group_manager" {
description = "Instance group resource."
value = try(
google_compute_instance_group_manager.default.0,
google_compute_region_instance_group_manager.default.0,
google_compute_instance_group_manager.default[0],
google_compute_region_instance_group_manager.default[0],
{}
)
}
@@ -37,15 +37,15 @@ output "health_check" {
value = (
var.health_check_config == null
? null
: google_compute_health_check.default.0
: google_compute_health_check.default[0]
)
}
output "id" {
description = "Fully qualified group manager id."
value = try(
google_compute_instance_group_manager.default.0.id,
google_compute_region_instance_group_manager.default.0.id,
google_compute_instance_group_manager.default[0].id,
google_compute_region_instance_group_manager.default[0].id,
null
)
}

4
modules/compute-mig/stateful-config.tf
View File

@@ -22,7 +22,7 @@ resource "google_compute_per_instance_config" "default" {
zone = var.location
name = each.key
instance_group_manager = try(
google_compute_instance_group_manager.default.0.name, null
google_compute_instance_group_manager.default[0].name, null
)
minimal_action = each.value.minimal_action
most_disruptive_allowed_action = each.value.most_disruptive_action
@@ -59,7 +59,7 @@ resource "google_compute_region_per_instance_config" "default" {
region = var.location
name = each.key
region_instance_group_manager = try(
google_compute_region_instance_group_manager.default.0.name, null
google_compute_region_instance_group_manager.default[0].name, null
)
minimal_action = each.value.minimal_action
most_disruptive_allowed_action = each.value.most_disruptive_action