Enable terraform_naming_convention in tflint (#3930)

* Draft terraform_naming_convention

* Two fast/stages fixes for terraform_naming_convention

* Disable terraform_naming_convention for resources for now

* module fixes for terraform_naming_convention

* tfdoc

* Remove "moved" from recipe and needs-fixing

* Fix moved for spoke_ra

* fix tests

* Use default (snake_case) for resources

* factory.terraform_data.project-preconditions

* First-pass migration of resources + tests

* Fix tests/modules/organization

* Require snake_case for variables; Add annotations for _testing

* permit _fast_debug variable

* Fix net_vpc_factory and net_vpc_firewall tests

* tfdoc addons and recipe

* Fix more tests

* Fix some net-global -> net_global tests

---------

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>

tests/modules/net_vpc_firewall/examples/basic.yaml

@@ -13,7 +13,7 @@
 # limitations under the License.
 
 values:
-  module.firewall.google_compute_firewall.allow-admins[0]:
+  module.firewall.google_compute_firewall.allow_admins[0]:
     allow:
     - ports: []
       protocol: all
@@ -30,7 +30,7 @@ values:
     source_tags: null
     target_service_accounts: null
     target_tags: null
-  module.firewall.google_compute_firewall.allow-tag-http[0]:
+  module.firewall.google_compute_firewall.allow_tag_http[0]:
     allow:
     - ports:
       - '80'
@@ -52,7 +52,7 @@ values:
     target_service_accounts: null
     target_tags:
     - http-server
-  module.firewall.google_compute_firewall.allow-tag-https[0]:
+  module.firewall.google_compute_firewall.allow_tag_https[0]:
     allow:
     - ports:
       - '443'
@@ -74,7 +74,7 @@ values:
     target_service_accounts: null
     target_tags:
     - https-server
-  module.firewall.google_compute_firewall.allow-tag-ssh[0]:
+  module.firewall.google_compute_firewall.allow_tag_ssh[0]:
     allow:
     - ports:
       - '22'