kovagoadi/hunfabric
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable terraform_naming_convention in tflint (#3930)

Browse Source 
* Draft terraform_naming_convention

* Two fast/stages fixes for terraform_naming_convention

* Disable terraform_naming_convention for resources for now

* module fixes for terraform_naming_convention

* tfdoc

* Remove "moved" from recipe and needs-fixing

* Fix moved for spoke_ra

* fix tests

* Use default (snake_case) for resources

* factory.terraform_data.project-preconditions

* First-pass migration of resources + tests

* Fix tests/modules/organization

* Require snake_case for variables; Add annotations for _testing

* permit _fast_debug variable

* Fix net_vpc_factory and net_vpc_firewall tests

* tfdoc addons and recipe

* Fix more tests

* Fix some net-global -> net_global tests

---------

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
This commit is contained in:
Simon Roberts
2026-05-06 16:06:26 +10:00
committed by GitHub
parent ba56d9afbc
commit 26dbaa2d6e
83 changed files with 570 additions and 284 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/modules/net_vpc_firewall/context.yaml
View File

@@ -13,7 +13,7 @@
# limitations under the License.
values:
google_compute_firewall.allow-admins[0]:
google_compute_firewall.allow_admins[0]:
allow:
- ports: []
protocol: all
@@ -33,7 +33,7 @@ values:
target_service_accounts: null
target_tags: null
timeouts: null
google_compute_firewall.allow-tag-http[0]:
google_compute_firewall.allow_tag_http[0]:
allow:
- ports:
- '80'
@@ -55,7 +55,7 @@ values:
target_tags:
- http-server
timeouts: null
google_compute_firewall.allow-tag-https[0]:
google_compute_firewall.allow_tag_https[0]:
allow:
- ports:
- '443'
@@ -77,7 +77,7 @@ values:
target_tags:
- https-server
timeouts: null
google_compute_firewall.allow-tag-ssh[0]:
google_compute_firewall.allow_tag_ssh[0]:
allow:
- ports:
- '22'
@@ -99,7 +99,7 @@ values:
target_tags:
- ssh
timeouts: null
google_compute_firewall.custom-rules["egress-test"]:
google_compute_firewall.custom_rules["egress-test"]:
allow:
- ports: []
protocol: all
@@ -131,7 +131,7 @@ values:
- serviceAccount:test@test-project.iam.gserviceaccount.com
target_tags: null
timeouts: null
google_compute_firewall.custom-rules["ingress-test"]:
google_compute_firewall.custom_rules["ingress-test"]:
allow:
- ports: []
protocol: all

8
tests/modules/net_vpc_firewall/examples/basic.yaml
View File

@@ -13,7 +13,7 @@
# limitations under the License.
values:
module.firewall.google_compute_firewall.allow-admins[0]:
module.firewall.google_compute_firewall.allow_admins[0]:
allow:
- ports: []
protocol: all
@@ -30,7 +30,7 @@ values:
source_tags: null
target_service_accounts: null
target_tags: null
module.firewall.google_compute_firewall.allow-tag-http[0]:
module.firewall.google_compute_firewall.allow_tag_http[0]:
allow:
- ports:
- '80'
@@ -52,7 +52,7 @@ values:
target_service_accounts: null
target_tags:
- http-server
module.firewall.google_compute_firewall.allow-tag-https[0]:
module.firewall.google_compute_firewall.allow_tag_https[0]:
allow:
- ports:
- '443'
@@ -74,7 +74,7 @@ values:
target_service_accounts: null
target_tags:
- https-server
module.firewall.google_compute_firewall.allow-tag-ssh[0]:
module.firewall.google_compute_firewall.allow_tag_ssh[0]:
allow:
- ports:
- '22'

18
tests/modules/net_vpc_firewall/examples/custom-rules.yaml
View File

@@ -14,11 +14,11 @@
values:
# the following 4 rules are already tested by simple.yaml
module.firewall.google_compute_firewall.allow-admins[0]: {}
module.firewall.google_compute_firewall.allow-tag-http[0]: {}
module.firewall.google_compute_firewall.allow-tag-https[0]: {}
module.firewall.google_compute_firewall.allow-tag-ssh[0]: {}
module.firewall.google_compute_firewall.custom-rules["allow-egress-rfc1918"]:
module.firewall.google_compute_firewall.allow_admins[0]: {}
module.firewall.google_compute_firewall.allow_tag_http[0]: {}
module.firewall.google_compute_firewall.allow_tag_https[0]: {}
module.firewall.google_compute_firewall.allow_tag_ssh[0]: {}
module.firewall.google_compute_firewall.custom_rules["allow-egress-rfc1918"]:
allow:
- ports: []
protocol: all
@@ -40,7 +40,7 @@ values:
source_tags: null
target_service_accounts: null
target_tags: null
module.firewall.google_compute_firewall.custom-rules["allow-egress-tag"]:
module.firewall.google_compute_firewall.custom_rules["allow-egress-tag"]:
allow:
- ports: []
protocol: all
@@ -61,7 +61,7 @@ values:
target_service_accounts: null
target_tags:
- target-tag
module.firewall.google_compute_firewall.custom-rules["allow-ingress-ntp"]:
module.firewall.google_compute_firewall.custom_rules["allow-ingress-ntp"]:
allow:
- ports:
- '123'
@@ -82,7 +82,7 @@ values:
target_service_accounts: null
target_tags:
- ntp-svc
module.firewall.google_compute_firewall.custom-rules["allow-ingress-tag"]:
module.firewall.google_compute_firewall.custom_rules["allow-ingress-tag"]:
allow:
- ports: []
protocol: all
@@ -102,7 +102,7 @@ values:
target_service_accounts: null
target_tags:
- target-tag
module.firewall.google_compute_firewall.custom-rules["deny-egress-all"]:
module.firewall.google_compute_firewall.custom_rules["deny-egress-all"]:
allow: []
deny:
- ports: []

6
tests/modules/net_vpc_firewall/examples/custom-ssh-default-rule.yaml
View File

@@ -13,9 +13,9 @@
# limitations under the License.
values:
module.firewall.google_compute_firewall.allow-tag-http[0]: {}
module.firewall.google_compute_firewall.allow-tag-https[0]: {}
module.firewall.google_compute_firewall.allow-tag-ssh[0]:
module.firewall.google_compute_firewall.allow_tag_http[0]: {}
module.firewall.google_compute_firewall.allow_tag_https[0]: {}
module.firewall.google_compute_firewall.allow_tag_ssh[0]:
allow:
- ports:
- '22'

6
tests/modules/net_vpc_firewall/examples/factory.yaml
View File

@@ -13,7 +13,7 @@
# limitations under the License.
values:
module.firewall.google_compute_firewall.custom-rules["allow-healthchecks"]:
module.firewall.google_compute_firewall.custom_rules["allow-healthchecks"]:
allow:
- ports:
- '80'
@@ -38,7 +38,7 @@ values:
target_service_accounts: null
target_tags:
- lb-backends
module.firewall.google_compute_firewall.custom-rules["allow-service-1-to-service-2"]:
module.firewall.google_compute_firewall.custom_rules["allow-service-1-to-service-2"]:
allow:
- ports:
- '80'
@@ -59,7 +59,7 @@ values:
target_service_accounts:
- service-2
target_tags: null
module.firewall.google_compute_firewall.custom-rules["block-telnet"]:
module.firewall.google_compute_firewall.custom_rules["block-telnet"]:
allow: []
deny:
- ports:

4
tests/modules/net_vpc_firewall/examples/local-ranges.yaml
View File

@@ -13,7 +13,7 @@
# limitations under the License.
values:
module.firewall.google_compute_firewall.custom-rules["allow-ingress-source-destination-ranges"]:
module.firewall.google_compute_firewall.custom_rules["allow-ingress-source-destination-ranges"]:
allow:
- ports: []
protocol: all
@@ -35,7 +35,7 @@ values:
source_tags: null
target_service_accounts: null
target_tags: null
module.firewall.google_compute_firewall.custom-rules["deny-egress-source-destination-ranges"]:
module.firewall.google_compute_firewall.custom_rules["deny-egress-source-destination-ranges"]:
allow: []
deny:
- ports: []

4
tests/modules/net_vpc_firewall/examples/no-ssh-default-rules.yaml
View File

@@ -13,8 +13,8 @@
# limitations under the License.
values:
module.firewall.google_compute_firewall.allow-tag-http[0]: {}
module.firewall.google_compute_firewall.allow-tag-https[0]: {}
module.firewall.google_compute_firewall.allow_tag_http[0]: {}
module.firewall.google_compute_firewall.allow_tag_https[0]: {}
counts:
google_compute_firewall: 2