kovagoadi/hunfabric
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable terraform_naming_convention in tflint (#3930)

Browse Source 
* Draft terraform_naming_convention

* Two fast/stages fixes for terraform_naming_convention

* Disable terraform_naming_convention for resources for now

* module fixes for terraform_naming_convention

* tfdoc

* Remove "moved" from recipe and needs-fixing

* Fix moved for spoke_ra

* fix tests

* Use default (snake_case) for resources

* factory.terraform_data.project-preconditions

* First-pass migration of resources + tests

* Fix tests/modules/organization

* Require snake_case for variables; Add annotations for _testing

* permit _fast_debug variable

* Fix net_vpc_factory and net_vpc_firewall tests

* tfdoc addons and recipe

* Fix more tests

* Fix some net-global -> net_global tests

---------

Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
This commit is contained in:
Simon Roberts
2026-05-06 16:06:26 +10:00
committed by GitHub
parent ba56d9afbc
commit 26dbaa2d6e
83 changed files with 570 additions and 284 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/api-gateway/recipe-multi-region/README.md
View File

@@ -18,9 +18,9 @@ Once deployed do the following to see that it works:
| name | description | type | required | default |
|---|---|:---:|:---:|:---:|
| [project_id](variables.tf#L27) | Identifier of the project. | <code>string</code> | ✓ | |
| [regions](variables.tf#L32) | List of regions to deploy the proxy in. | <code>list&#40;string&#41;</code> | ✓ | |
| [_testing](variables.tf#L17) | Populate this variable to avoid triggering the data source. | <code>object&#40;&#123;&#8230;&#125;&#41;</code> | | <code>null</code> |
| [project_id](variables.tf#L28) | Identifier of the project. | <code>string</code> | ✓ | |
| [regions](variables.tf#L33) | List of regions to deploy the proxy in. | <code>list&#40;string&#41;</code> | ✓ | |
| [_testing](variables.tf#L18) | Populate this variable to avoid triggering the data source. | <code>object&#40;&#123;&#8230;&#125;&#41;</code> | | <code>null</code> |
## Outputs

4
modules/api-gateway/recipe-multi-region/main.tf
View File

@@ -27,7 +27,7 @@ locals {
}
backends = [
for region in var.regions : {
backend = google_compute_region_network_endpoint_group.serverless-negs[region].id
backend = google_compute_region_network_endpoint_group.serverless_negs[region].id
}
]
}
@@ -136,7 +136,7 @@ module "glb" {
}
}
resource "google_compute_region_network_endpoint_group" "serverless-negs" {
resource "google_compute_region_network_endpoint_group" "serverless_negs" {
for_each = toset(var.regions)
provider = google-beta
name = "serverless-neg-${module.gateways[each.value].gateway_id}"

1
modules/api-gateway/recipe-multi-region/variables.tf
View File

@@ -14,6 +14,7 @@
* limitations under the License.
*/
# tflint-ignore: terraform_naming_convention
variable "_testing" {
description = "Populate this variable to avoid triggering the data source."
type = object({