kovagoadi/hunfabric
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add iam support to compute-vm module (#95)

Browse Source
This commit is contained in:
Ludovico Magnocavallo
2020-06-10 07:55:18 +02:00
committed by GitHub
parent 61bf03d143
commit 25d3b2ebdd
6 changed files with 69 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/modules/compute_vm/fixture/main.tf
View File

@@ -30,4 +30,6 @@ module "test" {
instance_count = var.instance_count
use_instance_template = var.use_instance_template
group = var.group
iam_roles = var.iam_roles
iam_members = var.iam_members
}

10
tests/modules/compute_vm/fixture/variables.tf
View File

@@ -19,6 +19,16 @@ variable "group" {
default = null
}
variable "iam_members" {
type = map(list(string))
default = {}
}
variable "iam_roles" {
type = list(string)
default = []
}
variable "instance_count" {
type = number
default = 1

37
tests/modules/compute_vm/test_plan.py
View File

@@ -21,35 +21,58 @@ FIXTURES_DIR = os.path.join(os.path.dirname(__file__), 'fixture')
def test_single_instance(plan_runner):
plan, resources = plan_runner(FIXTURES_DIR)
_, resources = plan_runner(FIXTURES_DIR)
assert len(resources) == 1
assert resources[0]['type'] == 'google_compute_instance'
def test_multiple_instances(plan_runner):
plan, resources = plan_runner(FIXTURES_DIR, instance_count=2)
_, resources = plan_runner(FIXTURES_DIR, instance_count=2)
assert len(resources) == 2
assert set(r['type'] for r in resources) == set(['google_compute_instance'])
def test_service_account(plan_runner):
plan, resources = plan_runner(FIXTURES_DIR, instance_count=2,
service_account_create='true')
_, resources = plan_runner(FIXTURES_DIR, instance_count=2,
service_account_create='true')
assert len(resources) == 3
assert 'google_service_account' in [r['type'] for r in resources]
def test_template(plan_runner):
plan, resources = plan_runner(FIXTURES_DIR, use_instance_template='true')
_, resources = plan_runner(FIXTURES_DIR, use_instance_template='true')
assert len(resources) == 1
assert resources[0]['type'] == 'google_compute_instance_template'
assert resources[0]['values']['name_prefix'] == 'test-'
def test_group(plan_runner):
plan, resources = plan_runner(FIXTURES_DIR, instance_count=2,
group='{named_ports={}}')
_, resources = plan_runner(FIXTURES_DIR, instance_count=2,
group='{named_ports={}}')
assert len(resources) == 3
assert set(r['type'] for r in resources) == set([
'google_compute_instance_group', 'google_compute_instance'
])
def test_iam(plan_runner):
iam_roles = '["roles/compute.instanceAdmin", "roles/iam.serviceAccountUser"]'
iam_members = (
'{"roles/compute.instanceAdmin" = ["user:a@a.com", "user:b@a.com"],'
'"roles/iam.serviceAccountUser" = ["user:a@a.com"]}'
)
_, resources = plan_runner(
FIXTURES_DIR, instance_count=2, iam_roles=iam_roles, iam_members=iam_members)
assert len(resources) == 6
assert set(r['type'] for r in resources) == set([
'google_compute_instance', 'google_compute_instance_iam_binding'])
iam_bindings = dict(
(r['index'], r['values']['members']) for r in resources if r['type']
== 'google_compute_instance_iam_binding'
)
assert iam_bindings == {
'roles/compute.instanceAdmin/test-1': ['user:a@a.com', 'user:b@a.com'],
'roles/compute.instanceAdmin/test-2': ['user:a@a.com', 'user:b@a.com'],
'roles/iam.serviceAccountUser/test-1': ['user:a@a.com'],
'roles/iam.serviceAccountUser/test-2': ['user:a@a.com'],
}