diff --git a/modules/cloud-run/README.md b/modules/cloud-run/README.md index 69318b927..99bd41278 100644 --- a/modules/cloud-run/README.md +++ b/modules/cloud-run/README.md @@ -121,6 +121,28 @@ module "cloud_run" { # tftest modules=1 resources=2 inventory=connector.yaml ``` +Note that if you are using Shared VPC you need to specify a subnet: + +```hcl +module "cloud_run" { + source = "./fabric/modules/cloud-run" + project_id = var.project_id + name = "hello" + containers = { + hello = { + image = "us-docker.pkg.dev/cloudrun/container/hello" + } + } + vpc_connector_create = { + subnet = { + name = "subnet-vpc-access" + project_id = "host-project" + } + } +} +# tftest modules=1 resources=2 inventory=connector-shared.yaml +``` + ### Traffic split This deploys a Cloud Run service with traffic split between two revisions. diff --git a/tests/modules/cloud_run/examples/connector-shared.yaml b/tests/modules/cloud_run/examples/connector-shared.yaml new file mode 100644 index 000000000..4db0a3bcc --- /dev/null +++ b/tests/modules/cloud_run/examples/connector-shared.yaml @@ -0,0 +1,53 @@ +# Copyright 2023 Google LLC +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +values: + module.cloud_run.google_cloud_run_service.service: + autogenerate_revision_name: false + location: europe-west1 + metadata: + - {} + name: hello + project: project-id + template: + - metadata: + - labels: null + spec: + - containers: + - args: null + command: null + env: [] + env_from: [] + image: us-docker.pkg.dev/cloudrun/container/hello + liveness_probe: [] + volume_mounts: [] + working_dir: null + volumes: [] + timeouts: null + module.cloud_run.google_vpc_access_connector.connector[0]: + ip_cidr_range: null + machine_type: e2-micro + max_throughput: 300 + min_throughput: 200 + name: hello + project: project-id + region: europe-west1 + subnet: + - name: subnet-vpc-access + project_id: host-project + timeouts: null + +counts: + google_cloud_run_service: 1 + google_vpc_access_connector: 1