diff --git a/modules/cloud-build-v2-connection/README.md b/modules/cloud-build-v2-connection/README.md index 901efefa8..d2052f0a7 100644 --- a/modules/cloud-build-v2-connection/README.md +++ b/modules/cloud-build-v2-connection/README.md @@ -540,7 +540,7 @@ module "cb_connection" { | [iam_bindings](variables-iam.tf#L23) | Authoritative IAM bindings in {KEY => {role = ROLE, members = [], condition = {}}}. Keys are arbitrary. | map(object({…})) | | {} | | [iam_bindings_additive](variables-iam.tf#L38) | Individual additive IAM bindings. Keys are arbitrary. | map(object({…})) | | {} | | [iam_by_principals](variables-iam.tf#L53) | Authoritative IAM binding in {PRINCIPAL => [ROLES]} format. Principals need to be statically defined to avoid cycle errors. Merged internally with the `iam` variable. | map(list(string)) | | {} | -| [repositories](variables.tf#L118) | Repositories. | map(object({…})) | | {} | +| [repositories](variables.tf#L118) | Repositories. | map(object({…})) | | {} | ## Outputs diff --git a/modules/cloud-build-v2-connection/main.tf b/modules/cloud-build-v2-connection/main.tf index 76f162cda..a385897f0 100644 --- a/modules/cloud-build-v2-connection/main.tf +++ b/modules/cloud-build-v2-connection/main.tf @@ -165,6 +165,9 @@ resource "google_cloudbuild_trigger" "triggers" { } } } - - filename = each.value.filename -} \ No newline at end of file + include_build_logs = each.value.include_build_logs + tags = each.value.tags + substitutions = each.value.substitutions + service_account = each.value.service_account + filename = each.value.filename +} diff --git a/modules/cloud-build-v2-connection/variables.tf b/modules/cloud-build-v2-connection/variables.tf index 93667e886..d07de7504 100644 --- a/modules/cloud-build-v2-connection/variables.tf +++ b/modules/cloud-build-v2-connection/variables.tf @@ -138,7 +138,7 @@ variable "repositories" { include_build_logs = optional(string) substitutions = optional(map(string), {}) service_account = optional(string) - tags = optional(map(string)) + tags = optional(list(string), []) })), {}) })) default = {} diff --git a/tests/modules/cloud_build_v2_connection/examples/bitbucket-cloud.yaml b/tests/modules/cloud_build_v2_connection/examples/bitbucket-cloud.yaml index 995459840..db0c0561d 100644 --- a/tests/modules/cloud_build_v2_connection/examples/bitbucket-cloud.yaml +++ b/tests/modules/cloud_build_v2_connection/examples/bitbucket-cloud.yaml @@ -40,7 +40,7 @@ values: service_account: null source_to_build: [] substitutions: null - tags: null + tags: [] timeouts: null trigger_template: [] webhook_config: [] diff --git a/tests/modules/cloud_build_v2_connection/examples/bitbucket-data-center.yaml b/tests/modules/cloud_build_v2_connection/examples/bitbucket-data-center.yaml index 90bb58a71..15b6064c8 100644 --- a/tests/modules/cloud_build_v2_connection/examples/bitbucket-data-center.yaml +++ b/tests/modules/cloud_build_v2_connection/examples/bitbucket-data-center.yaml @@ -40,7 +40,7 @@ values: service_account: null source_to_build: [] substitutions: null - tags: null + tags: [] timeouts: null trigger_template: [] webhook_config: [] diff --git a/tests/modules/cloud_build_v2_connection/examples/github-enterprise.yaml b/tests/modules/cloud_build_v2_connection/examples/github-enterprise.yaml index adee8fbdc..e861b8ea5 100644 --- a/tests/modules/cloud_build_v2_connection/examples/github-enterprise.yaml +++ b/tests/modules/cloud_build_v2_connection/examples/github-enterprise.yaml @@ -39,7 +39,7 @@ values: service_account: null source_to_build: [] substitutions: null - tags: null + tags: [] timeouts: null trigger_template: [] webhook_config: [] diff --git a/tests/modules/cloud_build_v2_connection/examples/github.yaml b/tests/modules/cloud_build_v2_connection/examples/github.yaml index e98268f08..47dfa8f3d 100644 --- a/tests/modules/cloud_build_v2_connection/examples/github.yaml +++ b/tests/modules/cloud_build_v2_connection/examples/github.yaml @@ -39,7 +39,7 @@ values: service_account: null source_to_build: [] substitutions: null - tags: null + tags: [] timeouts: null trigger_template: [] webhook_config: [] diff --git a/tests/modules/cloud_build_v2_connection/examples/gitlab.yaml b/tests/modules/cloud_build_v2_connection/examples/gitlab.yaml index ed183f888..77eacf7d2 100644 --- a/tests/modules/cloud_build_v2_connection/examples/gitlab.yaml +++ b/tests/modules/cloud_build_v2_connection/examples/gitlab.yaml @@ -39,7 +39,7 @@ values: service_account: null source_to_build: [] substitutions: null - tags: null + tags: [] timeouts: null trigger_template: [] webhook_config: []