From c8958c548f19b1dbcdcfb33dd3076c6a208f3f3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andras=20Gy=C3=B6mrey?= Date: Wed, 25 Nov 2020 17:32:53 +0100 Subject: [PATCH 1/2] monitoring is automatically enabled when monitoring.writer is enabled (#177) --- modules/gke-nodepool/main.tf | 1 + tests/modules/gke_nodepool/test_plan.py | 1 + 2 files changed, 2 insertions(+) diff --git a/modules/gke-nodepool/main.tf b/modules/gke-nodepool/main.tf index fdfb77bd8..81d711622 100644 --- a/modules/gke-nodepool/main.tf +++ b/modules/gke-nodepool/main.tf @@ -33,6 +33,7 @@ locals { : [ "https://www.googleapis.com/auth/devstorage.read_only", "https://www.googleapis.com/auth/logging.write", + "https://www.googleapis.com/auth/monitoring", "https://www.googleapis.com/auth/monitoring.write" ] ) diff --git a/tests/modules/gke_nodepool/test_plan.py b/tests/modules/gke_nodepool/test_plan.py index 1a71b4d49..a1f8872ed 100644 --- a/tests/modules/gke_nodepool/test_plan.py +++ b/tests/modules/gke_nodepool/test_plan.py @@ -22,6 +22,7 @@ OAUTH_SCOPE = ['https://www.googleapis.com/auth/cloud-platform'] OAUTH_SCOPES = [ 'https://www.googleapis.com/auth/devstorage.read_only', 'https://www.googleapis.com/auth/logging.write', + 'https://www.googleapis.com/auth/monitoring', 'https://www.googleapis.com/auth/monitoring.write'] From a866092328ea5a5fc3058811e3d85ead1b9139a8 Mon Sep 17 00:00:00 2001 From: Ludovico Magnocavallo Date: Wed, 25 Nov 2020 17:33:34 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cff840805..382b59e01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ All notable changes to this project will be documented in this file. - add support for MTU in `net-vpc` module - **incompatible change** access variables have been renamed in the `bigquery-dataset` module - add support for IAM to the `bigquery-dataset` module +- fix default OAuth scopes in `gke-nodepool` module ## [4.1.0] - 2020-11-16