From 495a5bbfffa87e1dca3eb530c31f655f380cfa5e Mon Sep 17 00:00:00 2001 From: lcaggio Date: Tue, 20 Sep 2022 10:36:12 +0200 Subject: [PATCH 1/2] Add Artifact registry Service Identity SA creation. --- modules/project/service-accounts.tf | 1 + tests/blueprints/gke/binauthz/test_plan.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/project/service-accounts.tf b/modules/project/service-accounts.tf index 7d584fa71..4bb730620 100644 --- a/modules/project/service-accounts.tf +++ b/modules/project/service-accounts.tf @@ -67,6 +67,7 @@ locals { } ) service_accounts_jit_services = [ + "artifactregistry.googleapis.com", "cloudasset.googleapis.com", "gkehub.googleapis.com", "pubsub.googleapis.com", diff --git a/tests/blueprints/gke/binauthz/test_plan.py b/tests/blueprints/gke/binauthz/test_plan.py index 6e176b1c0..cf012c061 100644 --- a/tests/blueprints/gke/binauthz/test_plan.py +++ b/tests/blueprints/gke/binauthz/test_plan.py @@ -16,4 +16,4 @@ def test_resources(e2e_plan_runner): "Test that plan works and the numbers of resources is as expected." modules, resources = e2e_plan_runner() assert len(modules) == 13 - assert len(resources) == 42 + assert len(resources) == 43 From f28dc5cb04002f04359e436d16552ae59ef2cb0a Mon Sep 17 00:00:00 2001 From: lcaggio Date: Tue, 20 Sep 2022 10:51:11 +0200 Subject: [PATCH 2/2] Fix tests --- blueprints/data-solutions/data-platform-foundations/README.md | 2 +- .../data_solutions/data_platform_foundations/test_plan.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/blueprints/data-solutions/data-platform-foundations/README.md b/blueprints/data-solutions/data-platform-foundations/README.md index 76810f54a..d2b885504 100644 --- a/blueprints/data-solutions/data-platform-foundations/README.md +++ b/blueprints/data-solutions/data-platform-foundations/README.md @@ -222,7 +222,7 @@ module "data-platform" { prefix = "myprefix" } -# tftest modules=42 resources=314 +# tftest modules=42 resources=315 ``` ## Customizations diff --git a/tests/blueprints/data_solutions/data_platform_foundations/test_plan.py b/tests/blueprints/data_solutions/data_platform_foundations/test_plan.py index e5db6ffc3..0e4b77f53 100644 --- a/tests/blueprints/data_solutions/data_platform_foundations/test_plan.py +++ b/tests/blueprints/data_solutions/data_platform_foundations/test_plan.py @@ -24,4 +24,4 @@ def test_resources(e2e_plan_runner): "Test that plan works and the numbers of resources is as expected." modules, resources = e2e_plan_runner(FIXTURES_DIR) assert len(modules) == 41 - assert len(resources) == 313 + assert len(resources) == 314